Closed
Bug 928040
Opened 9 years ago
Closed 9 years ago
Remove some prtypes.h inclusions from xpcom/
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
3.11 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: includehell, dieprtypesdie
Assignee | ||
Updated•9 years ago
|
Attachment #818615 -
Flags: review?(benjamin)
Comment 2•9 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1) > Created attachment 818615 [details] [diff] [review] > Remove some prtypes.h inclusions from xpcom/ Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp?
Comment 3•9 years ago
|
||
(In reply to Takanori MATSUURA from comment #2) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1) > > Created attachment 818615 [details] [diff] [review] > > Remove some prtypes.h inclusions from xpcom/ > > Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp? Yes, becaue the sole purpose of the file is to test NSPR types :) Eventually the file itself may be removed someday, but it is not now.
Updated•9 years ago
|
Attachment #818615 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to comment #3) > (In reply to Takanori MATSUURA from comment #2) > > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1) > > > Created attachment 818615 [details] [diff] [review] > > > Remove some prtypes.h inclusions from xpcom/ > > > > Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp? > > Yes, becaue the sole purpose of the file is to test NSPR types :) > Eventually the file itself may be removed someday, but it is not now. I don't think we'll want to remove that file, that test is actually very important!
Comment 5•9 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > I don't think we'll want to remove that file, that test is actually very > important! I meant to say I wish everyone (including NSPR) migrated to standard integer types.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #5) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > > I don't think we'll want to remove that file, that test is actually very > > important! > > I meant to say I wish everyone (including NSPR) migrated to standard integer > types. Oh, yeah, fair enough!
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f048fcdc03e7
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f048fcdc03e7
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•