Closed Bug 928040 Opened 8 years ago Closed 8 years ago

Remove some prtypes.h inclusions from xpcom/

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Remove some prtypes.h inclusions from xpcom/
3.11 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
No description provided.
Assignee: nobody → ehsan
Blocks: includehell, dieprtypesdie
Attachment #818615 - Flags: review?(benjamin)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> Created attachment 818615 [details] [diff] [review]
> Remove some prtypes.h inclusions from xpcom/

Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp?
(In reply to Takanori MATSUURA from comment #2)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> > Created attachment 818615 [details] [diff] [review]
> > Remove some prtypes.h inclusions from xpcom/
> 
> Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp?

Yes, becaue the sole purpose of the file is to test NSPR types :)
Eventually the file itself may be removed someday, but it is not now.
Attachment #818615 - Flags: review?(benjamin) → review+
(In reply to comment #3)
> (In reply to Takanori MATSUURA from comment #2)
> > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #1)
> > > Created attachment 818615 [details] [diff] [review]
> > > Remove some prtypes.h inclusions from xpcom/
> > 
> > Is prtypes.h still needed in xpcom/tests/TestPRIntN.cpp?
> 
> Yes, becaue the sole purpose of the file is to test NSPR types :)
> Eventually the file itself may be removed someday, but it is not now.

I don't think we'll want to remove that file, that test is actually very important!
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> I don't think we'll want to remove that file, that test is actually very
> important!

I meant to say I wish everyone (including NSPR) migrated to standard integer types.
(In reply to Masatoshi Kimura [:emk] from comment #5)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> > I don't think we'll want to remove that file, that test is actually very
> > important!
> 
> I meant to say I wish everyone (including NSPR) migrated to standard integer
> types.

Oh, yeah, fair enough!
https://hg.mozilla.org/mozilla-central/rev/f048fcdc03e7
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.