928081 - SetLocalDescription should check for SDP changes and give errors if changed.

Status: RESOLVED DUPLICATE of bug 1095226

(Core :: WebRTC: Signaling, defect, P2)

Description

[Ethan Hugg [:ehugg]]

We currently ignore SDP sent into SetLocalDescription.  We should instead check it against what we already have from CreatOffer or CreateAnswer and if changed, send up detailed errors of what was changed.  This is the first step in allowing changes to the SDP by the JS layer.

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: SetLocalDescription should check SDP changes

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: SetLocalDescription should check SDP changes

Comment 3

[basar.daldal]

Does this mean that Firefox currently uses the SDP created by createOffer method while doing setLocalDescription method and ignore the parameter passed to it? If this is how it works, how will an app developer change the SDP?

Comment 4

[Byron Campen [:bwc]]

(In reply to basar.daldal from comment #3)
> Does this mean that Firefox currently uses the SDP created by createOffer
> method while doing setLocalDescription method and ignore the parameter
> passed to it? If this is how it works, how will an app developer change the
> SDP?

   This is not the case anymore. Some work has already been done on this bug with the JSEP engine rewrite, and I believe we have other bugs for improving error checking on SetLocal, to catch modifications that we cannot support properly.