Closed Bug 9281 Opened 26 years ago Closed 26 years ago

Recent change broke --disable-mailnews build

Categories

(SeaMonkey :: UI Design, defect, P2)

Product:
SeaMonkey
Component:
UI Design
Platform:
Sun
Solaris
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tor, Assigned: radha)

Details

(Whiteboard: [071699]waiting to hear back from engineer)

Your change to xpfe/appshell/src/nsWebShellWindow.cpp (rev 1.1.50 1999/07/05 00:53:20) broke the non-necko --disable-mailnews build. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 107: Error: Could not open include file "nsIMsgComposeService.h". "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 108: Error: Could not open include file "nsMsgCompCID.h". "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 134: Error: NS_MSGCOMPOSESERVICE_CID is not defined. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: nsIMsgComposeService is not defined. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: :: is not a class name as required for a qualifer. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: The function GetIID must have a prototype. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: nsIMsgComposeService is not defined. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: msgcompose is not defined. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: nsIMsgComposeService is not defined. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: Operand expected instead of ")". "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2810: Error: Badly formed expression. "/cs/src/mozilla/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp", line 2814: Error: msgcompose is not defined.
Priority: P3 → P2
Target Milestone: M9
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Already fixed for M8. Mailnews files are not included in webshellwindow anymore.
radha -- how would I verify this one or is this a clode level fix that can only be verified by reviewing the code?
Whiteboard: [071699]waiting to hear back from engineer
If you pull a tree in unix with --disable-mailnews( don't know how you would pull in windows and mac) and try to build it, the compilation shouldn't stall in xpfe/appshell/src/nsWebShellWindow.cpp. If you want to look at the code, please look at my checin revision 1.158 of nsWebShellWindow.cpp. I don't #include the MsgCompose header files anymore.
Status: RESOLVED → VERIFIED
marking verified -- thanks for the tip radha
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.