928115 - Add support for higher fps modes for Pointgrey Flea3 1.3MP Mono USB 3.0 (VITA 1300)

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

This bug is about adding support for that to our capture utility, as well as making whatever modifications are necessary to eideticker to support capturing/processing at such a higher frame rate.

I now have a pointgrey camera that supports more than 60fps, so that's cool. I can verify that it works with their "flycapture" utility. It appears this support needs to be explicitly programmed in via the "format7" video mode, as it is not a standard mode supported by the pointgrey SDK. This is certainly possible, but I'll need to fiddle with the SDK options a bit to get it to work.

Comment 1

[William Lachance (:wlach)]

So it turns out that we need to support format7 for this device to work at all. That bumps up the priority here a bit...

Comment 2

[William Lachance (:wlach)]

Attachment: 0001-Bug-928115-Fix-various-minor-issues-with-pointgrey-c.patch

Mostly just fixing some nits as a lead up to more involved work.

Comment 3

[William Lachance (:wlach)]

Attachment: 0002-Bug-928115-Support-Flea3-FL3-U3-13Y3M-variable-frame.patch

This adds support for setting the framerate on the commandline, as well as basic support for the device. Basically just the prerequisites for getting this working before we add the higher fps support to eideticker itself.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 820603 [details] [diff] [review]
0002-Bug-928115-Support-Flea3-FL3-U3-13Y3M-variable-frame.patch

Review of attachment 820603 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unable to test this at this time but the changes look good to me. One comment about setting FPS on the new camera, but r+ with/without a change there.

::: src/videocapture/videocapture/pointgrey/Capture.cpp
@@ +136,5 @@
> +      frameRateProp.type = FRAME_RATE;
> +      cam.GetProperty(&frameRateProp);
> +      frameRateProp.onOff = true;
> +      frameRateProp.autoManualMode = false;
> +      frameRateProp.valueA = fps;

Can this be any value? We only allow 60fps with the original camera, should we limit the possible values for the new camera?

Comment 5

[William Lachance (:wlach)]

(In reply to Dave Hunt (:davehunt) from comment #4)
> Comment on attachment 820603 [details] [diff] [review]
> 0002-Bug-928115-Support-Flea3-FL3-U3-13Y3M-variable-frame.patch
> 
> Review of attachment 820603 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm unable to test this at this time but the changes look good to me. One
> comment about setting FPS on the new camera, but r+ with/without a change
> there.
> 
> ::: src/videocapture/videocapture/pointgrey/Capture.cpp
> @@ +136,5 @@
> > +      frameRateProp.type = FRAME_RATE;
> > +      cam.GetProperty(&frameRateProp);
> > +      frameRateProp.onOff = true;
> > +      frameRateProp.autoManualMode = false;
> > +      frameRateProp.valueA = fps;
> 
> Can this be any value? We only allow 60fps with the original camera, should
> we limit the possible values for the new camera?

Yes, surprisingly enough this can be any value on this particular device. You can set it arbitrarily inside the flycapture utility.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to William Lachance (:wlach) from comment #5)
> (In reply to Dave Hunt (:davehunt) from comment #4)
> > Can this be any value? We only allow 60fps with the original camera, should
> > we limit the possible values for the new camera?
> 
> Yes, surprisingly enough this can be any value on this particular device.
> You can set it arbitrarily inside the flycapture utility.

Interesting, thanks.

Comment 7

[William Lachance (:wlach)]

Pushed work-to-date:

https://github.com/mozilla/eideticker/commit/b335560f09cb7f2c50de4dc9a3c7a01faa8630e1
https://github.com/mozilla/eideticker/commit/6e78810d5694b6c7b4e12c93460167afa5f73d4e

(bug not yet completed yet so not closing)

Comment 8

[William Lachance (:wlach)]

Attachment: 0001-Bug-928115-Actually-support-higher-fps-modes-in-get-.patch

This actually enables us to get valid results with higher fps captures. Currently fps of greater than 100 doesn't work because of a limitation of either ffmpeg or the webm format. But it's a start.

Comment 9

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/e3a50afb7996c93f04890ac6289b263c400e565f

Comment 10

[Mike Lee [:mlee]]

Will, do you plan to keep this open to resolve the > 100fps issue you mentioned in comment 8 or will you work through that in a separate bug?

Comment 11

[William Lachance (:wlach)]

Sorry, this should have been resolved. I filed a followup for the 100fps issue in bug 943139.