928124 - Migrate Mozmill Tests for Firefox 25

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[u279076]

This bug tracks migration work for the mozmill-tests repository during Firefox 25's release.

Be advised of the following dates:

Monday, October 21, 2013:
 * mozilla-beta merges to mozilla-release for Firefox 25
 * Firefox 25RC, 17esr RC, and 24 ESR RC go to build

Monday, October 28, 2013: 
 * mozilla-aurora merges to mozilla-beta for Firefox 26, beta 1 goes to build
 * mozilla-central merges to mozilla-aurora for Firefox 27, updates disabled
 * mozilla-central version bumped to Firefox 28

Tuesday, October 29, 2013:
 * Firefox 25, 17esr, and 24esr released

Thursday, October 31, 2013:
 * Firefox 26.0b1 released

Friday, November 1, 2013:
 * Firefox 27.0a2 updates enabled on the aurora channel

Also be advised of the following QA Contacts:
 * Firefox 25: Anthony Hughes
 * Firefox 26: Juan Becerra
 * Firefox 27: Tracy Walker
 * Firefox 28: Anthony Hughes

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lets make sure we have a patch ready by today or early Monday morning so we are ready to get it landed at the same time as the merge for Firefox happens.

Comment 2

[Andrei Eftimie]

Assuming responsibility for the merge.

Will probably leave the actual merge for Monday morning, so we don't have to close the branches for the weekend.

Comment 3

[Andrei Eftimie]

Attachment: merge_beta_release.patch

The merge patch for mozilla-beta > mozilla-release

Comment 4

[Andrei Eftimie]

As a note, there were a few conflicts, all minor, mostly related to some bigger style changes we've had (eg: `else` on a new line, not on the same line with the closing bracket `}`)

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 819703 [details] [diff] [review]
merge_beta_release.patch

Review of attachment 819703 [details] [diff] [review]:
-----------------------------------------------------------------

Other than the small issue bellow, all looks good.

::: lib/localization.js
@@ +298,1 @@
>    } else if (node.hasAttributes()) {

This is wrong. else if should not have "}" before.

Comment 6

[Andrei Eftimie]

Attachment: merge_beta_release_3.patch

Updated patch.

Reports (OSX):
http://mozmill-crowd.blargon7.com/#/functional/report/f54ca65f73fd56845c30b7ab7dec5b55
http://mozmill-crowd.blargon7.com/#/functional/report/f54ca65f73fd56845c30b7ab7decdfc3
http://mozmill-crowd.blargon7.com/#/l10n/report/f54ca65f73fd56845c30b7ab7dec3131
http://mozmill-crowd.blargon7.com/#/endurance/report/f54ca65f73fd56845c30b7ab7ded4837
http://mozmill-crowd.blargon7.com/#/remote/report/f54ca65f73fd56845c30b7ab7ded233b
http://mozmill-crowd.blargon7.com/#/remote/report/f54ca65f73fd56845c30b7ab7ded02d1
http://mozmill-crowd.blargon7.com/#/addons/report/f54ca65f73fd56845c30b7ab7ded3def

Looks good.

Windows tests should also be done soon.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 819753 [details] [diff] [review]
merge_beta_release_3.patch

Review of attachment 819753 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good now.

Comment 8

[Andrei Eftimie]

Comment on attachment 819753 [details] [diff] [review]
merge_beta_release_3.patch

Review of attachment 819753 [details] [diff] [review]:
-----------------------------------------------------------------

We're all green on Windows as well.

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/2911e4d27d56 (mozilla-beta) [tag]
http://hg.mozilla.org/qa/mozmill-tests/rev/2911e4d27d56 (mozilla-release) [merge]
http://hg.mozilla.org/qa/mozmill-tests/rev/71213a1510a5 (mozilla-release) [tag]

Comment 9

[u279076]

FYI, Beta->Release migration completed at 3:56PM Pacific today and I expect the final Beta/RC builds to be generated overnight.

Comment 10

[Andrei Eftimie]

Attachment: merge_aurora_beta.patch

Aurora > Beta merge

Works fine from what I've tested until now (this was a really small merge).
I'll also add the Default > Aurora merge patch shortly.

Comment 11

[Andrei Eftimie]

Attachment: merge_default_aurora.patch

Default > Aurora merge

Only 1 conflict in regards to the skip statements of testFindInPage.js
We've thought about this, and together with Andreea we've decided to leave only the skip message on for the regression identified in bug 917771

Running more tests ATM

Comment 12

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 823326 [details] [diff] [review]
merge_aurora_beta.patch

Review of attachment 823326 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 13

[Andrei Eftimie]

Merge landed:

http://hg.mozilla.org/qa/mozmill-tests/rev/5ba469c3abfd (mozilla-aurora) [tag]
http://hg.mozilla.org/qa/mozmill-tests/rev/a664515ef396 (mozilla-beta) [merge]
http://hg.mozilla.org/qa/mozmill-tests/rev/21ce1907a0eb (mozilla-beta) [tag]
http://hg.mozilla.org/qa/mozmill-tests/rev/fafe39fb1854 (default) [tag]
http://hg.mozilla.org/qa/mozmill-tests/rev/0bfe251414b3 (mozilla-aurora) [merge]
http://hg.mozilla.org/qa/mozmill-tests/rev/fb099bc01fab (mozilla-aurora) [tag]

Comment 14

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 823340 [details] [diff] [review]
merge_default_aurora.patch

Review of attachment 823340 [details] [diff] [review]:
-----------------------------------------------------------------

Missed to flag this, while waiting for reports :)

Comment 15

[Andrei Eftimie]

This is done now.