928132 - remove restrict definition from opus build

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Tracking down bug 928091, gmaxwell pointed out he'd removed the need to have 'restrict' defined when building opus. The -Drestrict= in Makefile.in can therefore be removed now that we've updated to a a post-2012 version of the reference code.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Remove obsolete define

Comment 2

[Ralph Giles (:rillian)]

https://tbpl.mozilla.org/?tree=Try&rev=f9bb9752b965

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 818722 [details] [diff] [review]
Remove obsolete define

Add ted so he can resolve the race with bug 928091.

Chris, can you please confirm whether my patch (alone) resolves your issue?

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Build log with patch applied

Your patch alone does not fix my build.

The patch alone in bug 928091 does.

Comment 5

[Ralph Giles (:rillian)]

Ok, thanks. So inline is still a problem.

Ted, I suspect both of these are appropriate. We can remove the work-around from bug 928091 after the inline issue is fixed upstream.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 818722 [details] [diff] [review]
Remove obsolete define

Removing Ted based on the above and irc ack.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c07714a7a82

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c07714a7a82