Closed Bug 928132 Opened 6 years ago Closed 6 years ago

remove restrict definition from opus build

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

Tracking down bug 928091, gmaxwell pointed out he'd removed the need to have 'restrict' defined when building opus. The -Drestrict= in Makefile.in can therefore be removed now that we've updated to a a post-2012 version of the reference code.
Assignee: nobody → giles
Attachment #818722 - Flags: review?(tterribe)
Attachment #818722 - Flags: review?(tterribe) → review+
Blocks: 928091
Comment on attachment 818722 [details] [diff] [review]
Remove obsolete define

Add ted so he can resolve the race with bug 928091.

Chris, can you please confirm whether my patch (alone) resolves your issue?
Attachment #818722 - Flags: review?(ted)
Your patch alone does not fix my build.

The patch alone in bug 928091 does.
Ok, thanks. So inline is still a problem.

Ted, I suspect both of these are appropriate. We can remove the work-around from bug 928091 after the inline issue is fixed upstream.
Comment on attachment 818722 [details] [diff] [review]
Remove obsolete define

Removing Ted based on the above and irc ack.
Attachment #818722 - Flags: review?(ted)
https://hg.mozilla.org/mozilla-central/rev/2c07714a7a82
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.