Closed Bug 928140 Opened 10 years ago Closed 10 years ago

Fix spread-call-recursion on GGC

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

fix_unsafesetreservedslot-v0.diff
1.72 KB, patch
shu
: review+
Details | Diff | Splinter Review 
The off-main-thread IonBuilder patch exposed this pre-existing bug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f59a071d533

Disabled the test to stop the burning while we investigate.
Whiteboard: [leave open
Found it: missing post barrier in UnsafeSetReservedSlot.
Assignee: general → terrence
Status: NEW → ASSIGNED
Attachment #818795 - Flags: review?(shu)
Comment on attachment 818795 [details] [diff] [review]
fix_unsafesetreservedslot-v0.diff

Review of attachment 818795 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, sorry about the pain.
Attachment #818795 - Flags: review?(shu) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [leave open
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.