Manifest editor should be read-only for hosted apps

RESOLVED FIXED in Firefox 27

Status

()

Firefox
Developer Tools: WebIDE
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

Trunk
Firefox 27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

It should be made read-only, along with a notification telling the user about this.

Updated

4 years ago
Priority: P2 → P1
(Assignee)

Comment 1

4 years ago
Created attachment 820072 [details] [diff] [review]
Make Manifest Editor read-only for hosted apps

The makes the editor read-only, and swaps out the panel's name to indicate it is read-only.  Do we need want something more obvious?  I thought about some kind of notification, like the way warnings / errors are displayed, but it seemed like it would be too noisy and might make the user feel sad when they haven't done anything wrong.
Attachment #820072 - Flags: review?(paul)

Updated

4 years ago
Attachment #820072 - Flags: review?(paul) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 820733 [details] [diff] [review]
Make Manifest Editor read-only for hosted apps v2

Switches test to use a packaged app, since hosted apps aren't editable anymore.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=fb148d52e630
Attachment #820072 - Attachment is obsolete: true
Attachment #820733 - Flags: review?(paul)
(Assignee)

Updated

4 years ago
Blocks: 925921

Updated

4 years ago
Attachment #820733 - Flags: review?(paul) → review+

Updated

4 years ago
Blocks: 922144
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/08f5ba64a988
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/08f5ba64a988
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.