928201 - Defect - Download app bar displays 'Run' for non-executable content

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Downloads, defect, P2)

Description

[Jim Mathies [:jimm]]

str:
1) visit a page with an image
2) press hold on image and select save to image library

result: download app bar displays with a Run button display and set as the default.

Comment 1

[Marco Mucci [:MarcoM]]

Hey Matt, can you provide a point estimate.

Comment 2

[Matt Brubeck (:mbrubeck)]

p=1

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: s/Run/Open/

This patch uses "Open" instead of "Run", for all downloaded files.

(Also includes a minor change to silence build warnings about preprocessing files in this directory that don't need to be preprocessed.)

Comment 4

[Marina Samuel [:emtwo]]

Comment on attachment 824720 [details] [diff] [review]
s/Run/Open/

Review of attachment 824720 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/locales/en-US/chrome/browser.properties
@@ +58,4 @@
>  downloadSave=Save
>  downloadCancel=Cancel
>  downloadTryAgain=Try Again
> +downloadOpenNow=Open

Did you mean to have 'Open now' as the wording here? If not, can we just use the downloadOpen string and remove this?

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to Marina Samuel [:emtwo] from comment #4)
> Did you mean to have 'Open now' as the wording here?

Yes I did; thanks.  Fixed:
https://hg.mozilla.org/integration/fx-team/rev/c672c4cd6c7f

Comment 6

[:Gijs (he/him)]

Err. So this was merged to central already. And then I backed it out because it broke all the mochitest-mc because Sidebar.js has a preprocessed license header, it was taken out of the preprocessed components list, and that broke metro startup.

Merge: https://hg.mozilla.org/mozilla-central/rev/c672c4cd6c7f
Backout: https://hg.mozilla.org/mozilla-central/rev/d8fd5706493e

Comment 7

[Matt Brubeck (:mbrubeck)]

Oops, sorry.  Fixed the build error and relanded:
https://hg.mozilla.org/integration/fx-team/rev/7f907948d547

Green Try push:
https://tbpl.mozilla.org/?tree=Try&rev=0f37e80c1e62

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f907948d547

Comment 9

[Manuela Muntean [Away]]

Attachment: screenshot.png

While testing this with the latest Nightly, for iteration #18, I get the following:

1) the image is saved on disk, in Libraries\Pictures

2) the app bar shows that a download was made (for more details please see the attached screenshot)

Is this the intended behavior? Thanks!

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #9)
> 1) the image is saved on disk, in Libraries\Pictures
> 
> 2) the app bar shows that a download was made (for more details please see
> the attached screenshot)
> 
> Is this the intended behavior? Thanks!

Yes, that's expected.  Additionally, there should be notification bars that appear during and after the download.  If they aren't appearing, it might be because of bug 936897.

Comment 11

[Manuela Muntean [Away]]

Attachment: screenshot 2.png

Verified as fixed, for iteration #18, on Win 8 64-bit, with latest Nightly (build ID: 20131115030203).

I can see the notification bar shown in the attached screenshot.