928214 - [Bluetooth]bluedroid-Prototype: BluetootServiceBluedroid

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Only function prototype has been completed in this commit.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 928214 - [Bluetooth]bluedroid-Prototype: BluetootServiceBluedroidBug928214.patch

The first prototype of bluedroid for Gecko.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This patch needs to base on Bug 880610.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 928214 - [Bluetooth]bluedroid-Prototype: BluetootServiceBluedroid

Rebase version

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I have built jb 4.3 + bluedroid flag version.

Comment 5

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=2ec4188d26f1

Comment 6

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 818965 [details] [diff] [review]
Bug 928214 - [Bluetooth]bluedroid-Prototype: BluetootServiceBluedroid

Review of attachment 818965 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/moz.build
@@ +56,5 @@
> +       if CONFIG['MOZ_B2G_BT_BLUEZ']:
> +          CPP_SOURCES += [
> +             'linux/BluetoothDBusService.cpp',
> +             'gonk/BluetoothGonkService.cpp',
> +             'BluetoothServiceBluedroid.cpp',

BluetoothServiceBluedroid.cpp shouldn't be built if MOZ_B2G_BT_BLUEZ is defined.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Opps. Must be one warm in my head.

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 928214 - [Bluetooth]bluedroid-Prototype: BluetootServiceBluedroid, r=echou

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://tbpl.mozilla.org/?tree=Try&rev=2d3d69c231ce

Comment 10

[Eric Chou [:ericchou] [:echou]]

Unable to push to b2g-inbound since it's closed. Will push again once b2g-inbound is open.

Comment 11

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e09e6815a873

Comment 12

[Eric Chou [:ericchou] [:echou]]

backout: https://hg.mozilla.org/integration/b2g-inbound/rev/7238f0bd3ebd

Settings app will crash after this patch applied. Bug 880610 will be backed out later as well.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Move patch to bug 880610.