Closed
Bug 928237
Opened 12 years ago
Closed 12 years ago
clean up slowparse by refactoring calls to parser.domBuilder.currentNode
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
if we're pulling data out of parser.domBuilder.currentNode more than once, we should cache that as:
var currentNode = parser.domBuilder.currentNode;
and then do
return {
openTag: this._combine({
name: currentNode.nodeName.toLowerCase()
}, currentNode.parseInfo.openTag),
...
We're doing a lot of duplicated data pulling in a lot of places atm.
|
||
Comment 2•12 years ago
|
||
Attachment #829918 -
Flags: review?(pomax)
|
|
||
Comment 3•12 years ago
|
||
(In reply to xdchen from comment #2)
> Created attachment 829918 [details] [review]
> https://github.com/mozilla/slowparse/pull/59
this one is in
Flags: needinfo?(pomax)
|
|
||
Comment 4•12 years ago
|
||
Attachment #829918 -
Attachment is obsolete: true
Attachment #829918 -
Flags: review?(pomax)
Attachment #830817 -
Flags: review?(pomax)
Attachment #830817 -
Flags: review?(pomax) → review+
|
||
Comment 5•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/1af3c9a9c7dab515a422f4b438a6fcc19af6570f
code refactoring for bug 928237
https://github.com/mozilla/thimble.webmaker.org/commit/770148677aac7e9a65520726804fb48d15aa7012
Merge pull request #283 from xdchen/bug928237
code refactoring for bug 928237
landed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•