928237 - clean up slowparse by refactoring calls to parser.domBuilder.currentNode

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

if we're pulling data out of parser.domBuilder.currentNode more than once, we should cache that as:

var currentNode = parser.domBuilder.currentNode;

and then do

return {
  openTag: this._combine({
    name: currentNode.nodeName.toLowerCase()
  }, currentNode.parseInfo.openTag),
...

We're doing a lot of duplicated data pulling in a lot of places atm.

Comment 1

[xdchen(:xdchen)]

I will take it.

Comment 2

[xdchen(:xdchen)]

Attachment: https://github.com/mozilla/slowparse/pull/59

Comment 3

[xdchen(:xdchen)]

(In reply to xdchen from comment #2)
> Created attachment 829918 [details] [review]
> https://github.com/mozilla/slowparse/pull/59

this one is in

Comment 4

[xdchen(:xdchen)]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/283

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/1af3c9a9c7dab515a422f4b438a6fcc19af6570f
code refactoring for bug 928237

https://github.com/mozilla/thimble.webmaker.org/commit/770148677aac7e9a65520726804fb48d15aa7012
Merge pull request #283 from xdchen/bug928237

code refactoring for bug 928237

Comment 6

[Pomax]

landed