928244 - Generic rule to build sources in unified mode

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

See bug 928231 comment 4.  I think this is a bad idea.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add a UNIFIED_SOURCES variable to moz.build to trigger unified builds of the given sources

In a perfect world, that would not happen with a variable passthru, but i didn't feel like moving stuff out of variable passthru yet.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Add a UNIFIED_SOURCES variable to moz.build to trigger unified builds of the given sources

Fixed carriage return issues (also removed extra carriage returns that were in that code, and that didn't need to be there)

Comment 4

[Mike Hommey [:glandium]]

Attachment: Add a UNIFIED_SOURCES variable to moz.build to trigger unified builds of the given sources

Another fixup for when there are both c and c++ files in UNIFIED_SOURCES in the same directory.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 822694 [details] [diff] [review]
Add a UNIFIED_SOURCES variable to moz.build to trigger unified builds of the given sources

Review of attachment 822694 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

(Please stop bit rotting my patches!)

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8af00774f330

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8af00774f330