928295 - [DSDS][Gaia] Settings app should support sim security settings of multiple sim cards

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Users should be able to set sim security for multiple sim cards.

Comment 1

[Kai-Chih Hu [:khu]]

Arthur, is it something you can help? Thanks!

Comment 2

[Kai-Chih Hu [:khu]]

Sandip, can we move it to 1.4?

Comment 3

[Ken Chang[:kenkai]]

Arthur, are you going to take this bug?

Comment 4

[Sandip Kamat]

(In reply to Kevin Hu [:khu] from comment #2)
> Sandip, can we move it to 1.4?

This story looks to be a duplicate of bug 926350, which is marked for 1.3.

Comment 5

[Kai-Chih Hu [:khu]]

You're right, Sandip. 
I think this bug should block bug 926350.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I will integrate existing sim security panel into SimCardManager

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: WIP

I just moved Sim Card Security panel into Sim Manager. Right now, it works on single sim structure and views get rendered in DSDS structure. But still have to use new DSDS API to make it work for DSDS.

Comment 9

[Kai-Chih Hu [:khu]]

Plan to land it in the 1st week of sprint 6.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Anshul, 

we have tested a lot on this part but it seems that there are some cardState issue now.

Can you help us to give it a try there ? thanks !

Comment 11

[Kai-Chih Hu [:khu]]

Let's move forward without having comments from Anshul.

Comment 12

[Kai-Chih Hu [:khu]]

Forgot to say: my comment is the conclusion from the meeting with Anshul.

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

thanks Kevin.

Comment 14

[Kai-Chih Hu [:khu]]

May I know if this is planed to land before the end of this week? Or, next week? Thanks.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Kevin, 

I have WIP now but we may need more tests on stable devices to make sure it really works.

I think this bug would be postponed to next week. 

thanks.

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 829989 [details] [review]
WIP

Hi Arthur, 

I think this patch is ready to review. I am working on adding more tests for it and will ask Aknow for some details when airplane mode is on / off.

Thanks :)

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hsin-Yi, when airplane mode is on (Gaia will call mobileConnection.setRadioEnabled), is it possible for users to set defaultId on outgoing data / outgoing call and outgoing messages ? 

Currently in UX spec, there is no design for this special case. Before asking UX about the flow, I want to know the technical details behind setting them to make sure users can set defaultId or not when airplane mode is on. 

Thanks :)

Comment 18

[Ken Chang[:kenkai]]

(In reply to EJ Chen [:eragonj] from comment #17)
> Hsin-Yi, when airplane mode is on (Gaia will call
> mobileConnection.setRadioEnabled), is it possible for users to set defaultId
> on outgoing data / outgoing call and outgoing messages ? 
User can only dial up emergency call when airplane mode is on.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Per comment 18, it seems that we should still allow users to select a primary sim when airplane mode is enabled.

Comment 20

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After asking HsinYi, it is possible to set defaultId when we are in airplane mode.

Comment 21

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to EJ Chen [:eragonj] from comment #20)
> After asking HsinYi, it is possible to set defaultId when we are in airplane
> mode.

Agree with comment 20.

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 829989 [details] [review]
WIP

Great work EJ! The patch works well. There are a few minor issues I commented in github need to be addressed before merging. Please request a review after they are fixed. Thanks!

Comment 23

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 829989 [details] [review]
WIP

Hi Arthur,

I updated all code based on your comments and they all work well on single sim & dsds. 

please help me review the code again, thanks :)

Comment 24

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 829989 [details] [review]
WIP

Great work! Please merge the code with travis green, thanks!

Comment 25

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Fabrice, 

we are going to land this feature onto gaia master. please take a look when you have time. 

By the way, because right now gaia tree is all red, I will merge it later after weekend. 

Thanks :)

Comment 26

[[:fabrice] Fabrice Desré]

(In reply to EJ Chen [:eragonj] from comment #25)
> Hi Fabrice, 
> 
> we are going to land this feature onto gaia master. please take a look when
> you have time. 
> 
> By the way, because right now gaia tree is all red, I will merge it later
> after weekend. 
> 
> Thanks :)

Feel free to merge, thanks.

Comment 27

[Kai-Chih Hu [:khu]]

We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.

Comment 28

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Sorry for the late due to unstable testing environment on Travis and it made Gaia tree closed for few days. 

I just finally got green from Travis after rerun my tests for 1 more hour ... 

This patch is landed on :

gaia/master : 8a2b8d0e930aa16ec6d2271b336cfc0d531d05fa
gaia/v1.3 : c01f0ee5139194ffc3bced76fdf19c515f35304f

thanks all.

Comment 29

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to EJ Chen [:eragonj] from comment #28)
> Sorry for the late due to unstable testing environment on Travis and it made
> Gaia tree closed for few days. 
> 
> I just finally got green from Travis after rerun my tests for 1 more hour
> ... 
> 
> This patch is landed on :
> 
> gaia/master : 8a2b8d0e930aa16ec6d2271b336cfc0d531d05fa
> gaia/v1.3 : c01f0ee5139194ffc3bced76fdf19c515f35304f
> 
> thanks all.

Indeed great news, thanks EJ :)