928361 - Images in themes/platform/tabs/ don't need a 'tab' prefix.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Bug 923648 moved all tab-related images from the icons directory on Windows and Linux into a tabs directory instead. However, each image still contains a 'tab' prefix, which is no longer needed, since the image path will include the 'tab' part.

Comment 1

[Richard Marti (:Paenglab)]

You could also shorten the url's from list-style-image: url(chrome://messenger/skin/tabs/tabDragIndicator.png); to list-style-image: url(tabs/DragIndicator.png); like it is already done for the tab background.

Comment 2

[Josiah Bruner [:jsbruner]]

Attachment: Linux removal.

This removes the "tab" prefix on Linux. 

(I'm splitting these up to ease the reviewing process)

Comment 3

[Josiah Bruner [:jsbruner]]

Attachment: OS X removal.

Removes "tab" prefix on OS X.

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Windows removal.

Removal of "tab" for Windows.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 822676 [details] [diff] [review]
Linux removal.

Review of attachment 822676 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works. r=me

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 822677 [details] [diff] [review]
OS X removal.

Review of attachment 822677 [details] [diff] [review]:
-----------------------------------------------------------------

Looks also good. I haven't tested it but I suppose you have done it on your Mac.
r=me

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 822678 [details] [diff] [review]
Windows removal.

Review of attachment 822678 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the two comments fixed.

::: mail/themes/windows/jar.mn
@@ +212,5 @@
>    skin/classic/messenger/icons/identity.png                   (mail/icons/identity.png)
>    skin/classic/messenger/icons/tick.png                       (mail/icons/tick.png)
>    skin/classic/messenger/icons/error.png                      (mail/icons/error.png)
>    skin/classic/messenger/icons/cancel.png                     (mail/icons/cancel.png)
> +  skin/classic/messenger/tabs/arrow-left.png                  (mail/tabs/aarrow-left.png)

With only one a in arrow-left it would find the image and build.

@@ +222,5 @@
> +  skin/classic/messenger/tabs/activeMiddle.svg                (mail/tabs/activeMiddle.svg)
> +  skin/classic/messenger/tabs/activeStart.svg                 (mail/tabs/activeStart.svg)
> +  skin/classic/messenger/tabs/backgroundEnd.png               (mail/tabs/backgroundEnd.png)
> +  skin/classic/messenger/tabs/backgroundMiddle.png            (mail/tabs/backgroundMiddle.png)
> +  skin/classic/messenger/tabs/backgroundStart.png             (mail/backgroundStart.png)

If it would be (mail/tabs/backgroundStart.png) then it would also build.

Comment 8

[Josiah Bruner [:jsbruner]]

Attachment: Linux removal.

Updated commit message...

Comment 9

[Josiah Bruner [:jsbruner]]

Attachment: OS X removal.

Fixed a build problem and updated commit message.

Comment 10

[Josiah Bruner [:jsbruner]]

Attachment: Windows removal.

Fixed problems.

Thanks Richard!

Comment 11

[Josiah Bruner [:jsbruner]]

https://hg.mozilla.org/comm-central/rev/9a89f368426f
https://hg.mozilla.org/comm-central/rev/cd97cbc98824
https://hg.mozilla.org/comm-central/rev/031684b6571a