Images in themes/platform/tabs/ don't need a 'tab' prefix.

RESOLVED FIXED in Thunderbird 27.0

Status

Thunderbird
Theme
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: JosiahOne, Assigned: JosiahOne)

Tracking

Trunk
Thunderbird 27.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Bug 923648 moved all tab-related images from the icons directory on Windows and Linux into a tabs directory instead. However, each image still contains a 'tab' prefix, which is no longer needed, since the image path will include the 'tab' part.
You could also shorten the url's from list-style-image: url(chrome://messenger/skin/tabs/tabDragIndicator.png); to list-style-image: url(tabs/DragIndicator.png); like it is already done for the tab background.
Created attachment 822676 [details] [diff] [review]
Linux removal.

This removes the "tab" prefix on Linux. 

(I'm splitting these up to ease the reviewing process)
Attachment #822676 - Flags: review?(richard.marti)
Created attachment 822677 [details] [diff] [review]
OS X removal.

Removes "tab" prefix on OS X.
Attachment #822677 - Flags: review?(richard.marti)
Created attachment 822678 [details] [diff] [review]
Windows removal.

Removal of "tab" for Windows.
Attachment #822678 - Flags: review?(richard.marti)
Comment on attachment 822676 [details] [diff] [review]
Linux removal.

Review of attachment 822676 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works. r=me
Attachment #822676 - Flags: review?(richard.marti) → review+
Comment on attachment 822677 [details] [diff] [review]
OS X removal.

Review of attachment 822677 [details] [diff] [review]:
-----------------------------------------------------------------

Looks also good. I haven't tested it but I suppose you have done it on your Mac.
r=me
Attachment #822677 - Flags: review?(richard.marti) → review+
Comment on attachment 822678 [details] [diff] [review]
Windows removal.

Review of attachment 822678 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the two comments fixed.

::: mail/themes/windows/jar.mn
@@ +212,5 @@
>    skin/classic/messenger/icons/identity.png                   (mail/icons/identity.png)
>    skin/classic/messenger/icons/tick.png                       (mail/icons/tick.png)
>    skin/classic/messenger/icons/error.png                      (mail/icons/error.png)
>    skin/classic/messenger/icons/cancel.png                     (mail/icons/cancel.png)
> +  skin/classic/messenger/tabs/arrow-left.png                  (mail/tabs/aarrow-left.png)

With only one a in arrow-left it would find the image and build.

@@ +222,5 @@
> +  skin/classic/messenger/tabs/activeMiddle.svg                (mail/tabs/activeMiddle.svg)
> +  skin/classic/messenger/tabs/activeStart.svg                 (mail/tabs/activeStart.svg)
> +  skin/classic/messenger/tabs/backgroundEnd.png               (mail/tabs/backgroundEnd.png)
> +  skin/classic/messenger/tabs/backgroundMiddle.png            (mail/tabs/backgroundMiddle.png)
> +  skin/classic/messenger/tabs/backgroundStart.png             (mail/backgroundStart.png)

If it would be (mail/tabs/backgroundStart.png) then it would also build.
Attachment #822678 - Flags: review?(richard.marti) → review+
Created attachment 822800 [details] [diff] [review]
Linux removal.

Updated commit message...
Attachment #822676 - Attachment is obsolete: true
Attachment #822800 - Flags: review+
Created attachment 822801 [details] [diff] [review]
OS X removal.

Fixed a build problem and updated commit message.
Attachment #822677 - Attachment is obsolete: true
Attachment #822801 - Flags: review+
Created attachment 822802 [details] [diff] [review]
Windows removal.

Fixed problems.

Thanks Richard!
Attachment #822678 - Attachment is obsolete: true
Attachment #822802 - Flags: review+
Target Milestone: --- → Thunderbird 27.0
You need to log in before you can comment on or make changes to this bug.