928364 - ipdl and webidl unified sources dependencies are wrong

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The unified sources depend on the sources they include, which is wrong. The object they create do have such a dependency, but not the unified sources themselves.

On the other hand, they don't have a dependency on moz.build, which is about the only thing that could have an impact on their content.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove unified source dependencies completely, they're useless

The backend.RecursiveMakeBackend.built business ensures config.status reruns
when moz.build changes, which is the only thing that would affect unified
sources. Rerunning config.status updates unified sources if they need to
be updated. Once updated, normal object dependencies will ensure they are
rebuilt. Those same dependencies will ensure they are rebuilt when one of
the C/C++ sources they include change. IOW, unified sources don't need any
explicit dependencies generated by the backend.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #1)
> The backend.RecursiveMakeBackend.built business ensures config.status reruns
> when moz.build changes, which is the only thing that would affect unified
> sources. Rerunning config.status updates unified sources if they need to
> be updated. Once updated, normal object dependencies will ensure they are
> rebuilt. Those same dependencies will ensure they are rebuilt when one of
> the C/C++ sources they include change. IOW, unified sources don't need any
> explicit dependencies generated by the backend.

What if the unified sources get removed?  dom/bindings/Makefile.in puts them in $GARBAGE, for instance.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Nathan Froyd (:froydnj) from comment #2)
> What if the unified sources get removed?  dom/bindings/Makefile.in puts them
> in $GARBAGE, for instance.

mmmm they should be removed by the backend imho. It's not a terrible problem, though, because that would mean a moz.build change, which would mean a *.mk change with a list with less unified sources.
(I mean, there are *many* things we don't garbage out, and that's a separate issue)

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 820845 [details] [diff] [review]
Remove unified source dependencies completely, they're useless

Review of attachment 820845 [details] [diff] [review]:
-----------------------------------------------------------------

That logic makes sense to me. I think.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f52040ede0d

Comment 6

[Mike Hommey [:glandium]]

Guess what, the GARBAGE thing Nathan was talking about made this patch break PGO builds.
Backed out for now.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d1266f5c051

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcd779a72dd3

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcd779a72dd3