928404 - make push does not work on b2g

Status: RESOLVED FIXED

(Testing Graveyard :: Orangutan, defect)

Description

[William Lachance (:wlach)]

As we discovered in bug 916809, Android's su does not follow standard unix semantics, so we'll need to do something different for b2g which has that copy of su.

Comment 1

[William Lachance (:wlach)]

Attachment: Remove su requirements of make push

/data/local is pretty much where we want it to go anyway in most cases. This also has the advantage of working on unrooted android devices.

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 819193 [details] [diff] [review]
Remove su requirements of make push

Review of attachment 819193 [details] [diff] [review]:
-----------------------------------------------------------------

That seems very sensible. 

Is there some orangutan and/or eideticker documentation that ought to be updated with this change?

Comment 3

[William Lachance (:wlach)]

(In reply to Geoff Brown [:gbrown] from comment #2)
> Comment on attachment 819193 [details] [diff] [review]

> Is there some orangutan and/or eideticker documentation that ought to be
> updated with this change?

Nope, the docs didn't talk about the path we pushed to at all. Hurrah.

Comment 4

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla-b2g/orangutan/commit/ed3c5d6881134f37b374f9445b7777992b4eab03