make push does not work on b2g

RESOLVED FIXED

Status

Testing Graveyard
Orangutan
RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

As we discovered in bug 916809, Android's su does not follow standard unix semantics, so we'll need to do something different for b2g which has that copy of su.
Created attachment 819193 [details] [diff] [review]
Remove su requirements of make push

/data/local is pretty much where we want it to go anyway in most cases. This also has the advantage of working on unrooted android devices.
Attachment #819193 - Flags: review?(gbrown)
Comment on attachment 819193 [details] [diff] [review]
Remove su requirements of make push

Review of attachment 819193 [details] [diff] [review]:
-----------------------------------------------------------------

That seems very sensible. 

Is there some orangutan and/or eideticker documentation that ought to be updated with this change?
Attachment #819193 - Flags: review?(gbrown) → review+
(In reply to Geoff Brown [:gbrown] from comment #2)
> Comment on attachment 819193 [details] [diff] [review]

> Is there some orangutan and/or eideticker documentation that ought to be
> updated with this change?

Nope, the docs didn't talk about the path we pushed to at all. Hurrah.
Pushed: https://github.com/mozilla-b2g/orangutan/commit/ed3c5d6881134f37b374f9445b7777992b4eab03
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

6 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.