Improve test_import_contacts_from_SIM.py on aurora

RESOLVED FIXED

Status

Product:
Firefox OS
Component:
Gaia::UI Tests
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: Teodosia Pop, Assigned: AndreiH)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gaia-ui-test])

Attachments

(1 attachment)

PR
46 bytes, text/x-github-pull-request
Teodosia Pop
: review+
Details | Review | Splinter Review
(Reporter)

Description

•
5 years ago 
We are currently returning the Contacts app after tapping import_from_sim: https://github.com/mozilla-b2g/gaia/blob/v1.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sim.py#L25

when we should actually go back in the Contacts app then assert that the contacts are there.

This was for master in bug 927886 and the changes are similar.
 (Reporter)

Updated

•
5 years ago
Whiteboard: [gaia-ui-test]
Assignee: nobody → alin.trif
Blocks: 928882
No longer blocks: 928882
Depends on: 928882
Depends on: 928635

Updated

•
5 years ago
Depends on: 928954

Updated

•
5 years ago
No longer depends on: 928882
 (Assignee)

Comment 1

•
5 years ago 
Created attachment 822182 [details] [review]
PR

Pointer to PR https://github.com/mozilla-b2g/gaia/pull/13089
Attachment #822182 - Flags: ui-review?(alin.trif)
Attachment #822182 - Flags: superreview?(zcampbell)
Attachment #822182 - Flags: review?(moz.teodosia)
 (Assignee)

Updated

•
5 years ago
Assignee: alin.trif → andrei.hutusoru
 (Reporter)

Updated

•
5 years ago
Attachment #822182 - Flags: review?(moz.teodosia) → review+

Comment 2

•
5 years ago 
https://github.com/mozilla-b2g/gaia/commit/c99a4e0ff67d403aa993d877cae82aef012d3019
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

•
5 years ago
Attachment #822182 - Flags: ui-review?(trifandreialin)
Attachment #822182 - Flags: superreview?(zcampbell)
You need to log in before you can comment on or make changes to this bug.