Closed Bug 928421 Opened 6 years ago Closed 6 years ago

Please re-add --enable-threadsafe and make it a no-op

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: gkw, Assigned: terrence)

Details

Attachments

(1 file, 1 obsolete file)

Bug 924986 made --enable-threadsafe the default configuration by removing it and adding --disable-threadsafe. This can break bisection for previous builds, so please re-add it and make it a no-op. As a side-note, it has no need to be added to `./js -h`.

Assigned to Terrence after our quick IRC chat.
Attached patch noop_enable_threadsafe-v0.diff (obsolete) — Splinter Review
Attachment #819076 - Attachment is obsolete: true
Attachment #819083 - Flags: review?(jwalden+bmo)
Comment on attachment 819083 [details] [diff] [review]
noop_enable_threadsafe-v1.diff

Review of attachment 819083 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, better than the last one per IRC.  :-)
Attachment #819083 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/43f17af3f704
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.