928503 - python gaia unit tests misses some test files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

It appears that the python gaia-unit-test only runs files that end in '_test.js' that are immediately in an 'unit' directory.  Some apps, such as communications/contacts, have tests in sub-directories under 'unit'.  These run fine with the javascript client in travis and should probably run in python on tbpl as well.

Comment 1

[Jonathan Griffin (:jgriffin)]

Whoops!

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Note, some of the tests in sub-directories have their old names in the disabled.json.  For example:

  communications/contacts/test/unit/contacts_list_test.js

Is now:

  communications/contacts/test/unit/view/list_test.js

That may actually be the only instance of that kind if issue.

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12989

Pointer to Github pull-request

Comment 4

[Anthony Ricaud (:rik)]

Can we wait till we've re-enable all the tests disabled by bug 928915 before landing this?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Anthony Ricaud (:rik) from comment #4)
> Can we wait till we've re-enable all the tests disabled by bug 928915 before
> landing this?

This is against the python driver for the gaia unit tests, not the gaia ui tests.  It will only effect TBPL at the moment which is already completely red because of bug 927493.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Newly run tests that fail after this goes in (for unit tests):

  communications/contacts/test/unit/views/form_test.js
  calendar/test/unit/templates/alarm_test.js

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 819920 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12989

Looks good to me.  r=me (Assuming I am allowed to review this.  I'm not a peer on this particular code.)

I'd say land this and then we can keep working to make the unit tests green.

Comment 8

[Jonathan Griffin (:jgriffin)]

https://github.com/mozilla-b2g/gaia/commit/875dbde53720d597f85be37090d6be3c0612001b

> I'd say land this and then we can keep working to make the unit tests green.

That's what I was thinking too.