928537 - Datachannel streams should be larger than u16

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Ethan Hugg [:ehugg]]

Chrome canary is sending us this:

a=sctpmap:5000 webrtc-datachannel 65536

And we are responding with

a=sctpmap:5000 webrtc-datachannel 0

because we are storing this value in 16 bits.  We should move to a larger unsigned type.

Comment 1

[Ethan Hugg [:ehugg]]

Via correspondence with Jesup over email it appears that we should be limiting this to MAX_NUM_STREAMS instead.  This value is defined in DataChannelProtocol.h

#define MAX_NUM_STREAMS (2048)

So I think we should be reflecting the value of streams unless it is greater than MAX_NUM_STREAMS, in which case we should return the MAX_NUM_STREAMS value.   Perhaps I should also be checking for < 1 and setting to 1 in that case as well.

Comment 2

[Ethan Hugg [:ehugg]]

Attachment: Datachannel streams should be kept in the range 1 to MAX_NUM_STREAMS

Comment 3

[Ethan Hugg [:ehugg]]

Comment on attachment 819229 [details] [diff] [review]
Datachannel streams should be kept in the range 1 to MAX_NUM_STREAMS


Tested by building with WEBRTC_DATACHANNEL_STREAMS_DEFAULT to 65536.

Comment 4

[Ethan Hugg [:ehugg]]

Doing a try run since the include path was changed:

https://tbpl.mozilla.org/?tree=Try&rev=2707caa1fa2d

Comment 5

[Ethan Hugg [:ehugg]]

Try looks good, requesting checkin.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a75117d380f

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1a75117d380f