Closed Bug 928541 Opened 6 years ago Closed 6 years ago

MediaEngineTabVideoSource.cpp:259:15: warning: unused variable ‘cairoFormat’ [-Wunused-variable]

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix v1: drop the variable
914 bytes, patch
blassey
: review+
Details | Diff | Splinter Review 
New build warning:
{
content/media/webrtc/MediaEngineTabVideoSource.cpp:259:15: warning: unused variable ‘cairoFormat’ [-Wunused-variable]

    ImageFormat cairoFormat = CAIRO_SURFACE;
}
blassey, can we just drop this variable (per attached patch), or did you mean to use it somehow?
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #819207 - Flags: review?(blassey.bugs)
Comment on attachment 819207 [details] [diff] [review]
fix v1: drop the variable

Review of attachment 819207 [details] [diff] [review]:
-----------------------------------------------------------------

It was used for old code that got deleted before the final patch
Attachment #819207 - Flags: review?(blassey.bugs) → review+
Cool. Thanks for the review!
Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a8d2e83ab66
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/9a8d2e83ab66
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.