Closed
Bug 928541
Opened 8 years ago
Closed 8 years ago
MediaEngineTabVideoSource.cpp:259:15: warning: unused variable ‘cairoFormat’ [-Wunused-variable]
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
914 bytes,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
New build warning: { content/media/webrtc/MediaEngineTabVideoSource.cpp:259:15: warning: unused variable ‘cairoFormat’ [-Wunused-variable] ImageFormat cairoFormat = CAIRO_SURFACE; }
Assignee | ||
Comment 1•8 years ago
|
||
blassey, can we just drop this variable (per attached patch), or did you mean to use it somehow?
Comment 2•8 years ago
|
||
Comment on attachment 819207 [details] [diff] [review] fix v1: drop the variable Review of attachment 819207 [details] [diff] [review]: ----------------------------------------------------------------- It was used for old code that got deleted before the final patch
Attachment #819207 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Cool. Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a8d2e83ab66
Flags: in-testsuite-
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a8d2e83ab66
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•