928542 - Thumbnails are missing on trailers.apple.com

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alice0775 White]

Attachment: screen shot

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/4e7d1e2c93a6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20131018030206

I noticed a problem when I test Bug 928379 .
Thumbnails are missing.


Steps To Reproduce:
1. Open http://trailers.apple.com/trailers/

Actual Results:
The followinf message is shown insted of thumbnails

We’re sorry
The Apple.com Trailers Application has encountered an error. The team’s been notified and we’re looking into it.
Unexpected error.

Expected Results:
Thumbnails should be shown

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/d54e0cce6c17
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130902065759
Bad:
http://hg.mozilla.org/mozilla-central/rev/541ba36e8b9d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130903041150
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d54e0cce6c17&tochange=541ba36e8b9d


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f66ac3e480ca
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130902085957
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/24ffdfbf55d8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130902100657
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f66ac3e480ca&tochange=24ffdfbf55d8

Suspected: Bug 911204  or Bug 906788

Comment 1

[Alice0775 White]

In local build
last Good: f66ac3e480ca
First bad: abb25a18b5a5

Regressed by: abb25a18b5a5	Brian Hackett — Bug 906788 - Construct TypeObject newScript information using MIR, r=jandem.

Comment 2

[Alex Keybl [:akeybl]]

major web property, needs resolution prior to release

Comment 3

[David Chalkley]

(I am heading off to Uni so I'll update this when I get back)

I can concur that this has been effecting Aurora for about a month now – should of reported this bug when I first noticed it (sadly I can’t remember what version I was on prior).

This is effecting both the Windows and Mac versions of Firefox Aurora.
On my MacBook I am currently using 26.0a2 (2013-10-23) x64.

Comment 4

[Brian Hackett [Laid off!]]

Attachment: patch

During the definite properties analysis, when IonBuilder constant folded property reads, no instructions were generated to indicate to the later processing that the read occurred.

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b32d240c9a66

Comment 6

[Brian Hackett [Laid off!]]

Comment on attachment 821706 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 906788
User impact if declined: broken websites
Testing completed (on m-c, etc.): on m-i
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b32d240c9a66

Comment 8

[Ekanan Ketunuti]

Verified on Nightly 27.0a1 buildid 20131025030239

Comment 9

[Ed Morley [:emorley]]

[/c/src-gecko/aurora]$ transplant b32d240c9a66
searching for changes
applying b32d240c9a66
patching file js/src/jit/IonBuilder.cpp
Hunk #1 FAILED at 8039
1 out of 1 hunks FAILED -- saving rejects to file js/src/jit/IonBuilder.cpp.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

Comment 10

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dba809d7ee66

Comment 11

[Ekanan Ketunuti]

Verified fixed on

- Aurora 26.0a2 BuildID 20131028111546
  https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=cc371f7026a8
- Beta 26 https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=73ef4f13486f