Closed Bug 928579 Opened 6 years ago Closed 4 years ago

Backout bug 793906 to re-enable desktop Signin-to-Web UI.

Categories

(Core Graveyard :: Identity, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MattN, Assigned: MattN, NeedInfo)

References

Details

Attachments

(1 file)

Work is starting again on native UI to sign into a website with Persona and since the code which was disabled in bug 793906 still "works", we can re-enable it to ease development.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=193347f7beda
Attachment #819249 - Flags: review?(dolske)
Attachment #819249 - Flags: feedback?(ozten.bugs)
Comment on attachment 819249 [details] [diff] [review]
v.1 Backout 793906 (with a switch to mochitest.ini)

A note that browser/modules/test/Makefile.in contains a comment which removes tests. This was also part of 793906. I think this is okay, just calling it out.
Attachment #819249 - Flags: feedback?(ozten.bugs) → feedback+
(In reply to Austin King [:ozten] from comment #1)
> A note that browser/modules/test/Makefile.in contains a comment which
> removes tests. This was also part of 793906. I think this is okay, just
> calling it out.

I moved it to browser/modules/test/browser.ini (where it belongs now) and enabled it. It passed on my try push and locally.
Comment on attachment 819249 [details] [diff] [review]
v.1 Backout 793906 (with a switch to mochitest.ini)

Review of attachment 819249 [details] [diff] [review]:
-----------------------------------------------------------------

Talked with Matt, since I wanted to understand if this was turning on something that wasn't ready or otherwise surprise users... The pref that's actually controlling this is still off, and Matt says if a user currently had this pref enabled it's a broken experience anyway. So this doesn't make anything worse, and actually makes things a whole lot better in enabling further iteration of getting this up to speed. Yay! \o/
Attachment #819249 - Flags: review?(dolske) → review+
Should this be marked FIXED now?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Flags: needinfo?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.