928581 - STK: Tone plays forever when missing alphaId

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Carol Yang [:cyang]]

When alphaId is empty (length='00') or none is sent, the tone plays forever. There should be some default timeout where tone stops and TR is sent.

Empty alphaId:
PDU used: D01281030120008202810385008E010284020103
JSON message sent: RIL:StkCommand{ commandNumber : 1, typeOfCommand : 32, commandQualifier : 0, options : { tone : '', duration : { timeUnit : 1, timeInterval : 3,  },  },  }

No alphaId:
PDU used: D0108103012001820281038E01038402010A
JSON message sent: RIL:StkCommand{ commandNumber : 1, typeOfCommand : 32, commandQualifier : 1, options : { text : '', tone : '', duration : { timeUnit : 1, timeInterval : 10,  }, isVibrate : true,  },  }

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

With 928582 patch, a default timeout is set. Can you check if the 928582 patch fixes also this one?

Comment 2

[Carol Yang [:cyang]]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #1)
> With 928582 patch, a default timeout is set. Can you check if the 928582
> patch fixes also this one?

Thanks for getting back so quickly!

The patch fix from 928582 doesn't fix this issue (and theoretically should not). In this case, duration was defined. So the tone should stop playing based on the duration but that's not happening. You should be able to easily replicate with the PDUs I provided above.

Comment 3

[Bruce Huang [:bhuang] (inactive)]

(In reply to Carol Yang [:cyang] from comment #0)
> When alphaId is empty (length='00') or none is sent, the tone plays forever.
> There should be some default timeout where tone stops and TR is sent.
> 

Is there a recommended timeout for this that we can reference?

Comment 4

[Preeti Raghunath(:Preeti)]

Product,

Please recommend a default timeout.

Comment 5

[Carol Yang [:cyang]]

(In reply to Bruce Huang (:bhuang) from comment #3)
> (In reply to Carol Yang [:cyang] from comment #0)
> > When alphaId is empty (length='00') or none is sent, the tone plays forever.
> > There should be some default timeout where tone stops and TR is sent.
> > 
> 
> Is there a recommended timeout for this that we can reference?

This is not specified in the TS. I think Fernando just set it default to 5 seconds for bug 928582.

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Add a timeout to stop player if no text message is provided

Comment 7

[Preeti Raghunath(:Preeti)]

blocking CS.

Comment 8

[Carol Yang [:cyang]]

Comment on attachment 821516 [details] [review]
Add a timeout to stop player if no text message is provided

Looks good Fernando!

Comment 9

[Peter Dolanjski [:pdol]]

(In reply to Preeti Raghunath(:Preeti) from comment #4)
> Product,
> 
> Please recommend a default timeout.

Unless Bruce wants something other than the 5 seconds suggested in comment#5, then 5 seconds should be good.

Comment 10

[Bruce Huang [:bhuang] (inactive)]

As there is no spec definition for it, 5 seconds works.

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Rebased and fixed index.html to load JS in the correct order.

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Bruce Huang (:bhuang) from comment #10)
> As there is no spec definition for it, 5 seconds works.

Bug 928582 sets 5 secs as default timeout.
https://github.com/mozilla-b2g/gaia/pull/12965/files#diff-7b4cd981b7b9c4669c33a8cecd441af2R11

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Rebased and landed: https://github.com/mozilla-b2g/gaia/commit/e8139d2f325a15a3ea9e54b2ddd490d87044bb7d

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e8139d2f325a15a3ea9e54b2ddd490d87044bb7d to:
v1.2: 1a374767b276cd01d020ae1a22c4cb8b08a0f70f