Closed Bug 928581 Opened 9 years ago Closed 9 years ago

STK: Tone plays forever when missing alphaId

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86_64
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
1.2 C4(Nov8)
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: cyang, Assigned: frsela)

References

Details

Attachments

(1 file)

When alphaId is empty (length='00') or none is sent, the tone plays forever. There should be some default timeout where tone stops and TR is sent.

Empty alphaId:
PDU used: D01281030120008202810385008E010284020103
JSON message sent: RIL:StkCommand{ commandNumber : 1, typeOfCommand : 32, commandQualifier : 0, options : { tone : '', duration : { timeUnit : 1, timeInterval : 3,  },  },  }

No alphaId:
PDU used: D0108103012001820281038E01038402010A
JSON message sent: RIL:StkCommand{ commandNumber : 1, typeOfCommand : 32, commandQualifier : 1, options : { text : '', tone : '', duration : { timeUnit : 1, timeInterval : 10,  }, isVibrate : true,  },  }
Summary: STK: No terminal response sent for PLAY_TONE and tone plays forever → STK: Tone plays forever when missing alphaId
blocking-b2g: --- → koi?
With 928582 patch, a default timeout is set. Can you check if the 928582 patch fixes also this one?
Depends on: 928582
Flags: needinfo?(cyang)
(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #1)
> With 928582 patch, a default timeout is set. Can you check if the 928582
> patch fixes also this one?

Thanks for getting back so quickly!

The patch fix from 928582 doesn't fix this issue (and theoretically should not). In this case, duration was defined. So the tone should stop playing based on the duration but that's not happening. You should be able to easily replicate with the PDUs I provided above.
Flags: needinfo?(cyang)
(In reply to Carol Yang [:cyang] from comment #0)
> When alphaId is empty (length='00') or none is sent, the tone plays forever.
> There should be some default timeout where tone stops and TR is sent.
> 

Is there a recommended timeout for this that we can reference?
Flags: needinfo?(cyang)
Product,

Please recommend a default timeout.
Flags: needinfo?(ffos-product)
(In reply to Bruce Huang (:bhuang) from comment #3)
> (In reply to Carol Yang [:cyang] from comment #0)
> > When alphaId is empty (length='00') or none is sent, the tone plays forever.
> > There should be some default timeout where tone stops and TR is sent.
> > 
> 
> Is there a recommended timeout for this that we can reference?

This is not specified in the TS. I think Fernando just set it default to 5 seconds for bug 928582.
Flags: needinfo?(cyang)
blocking CS.
blocking-b2g: koi? → koi+
Comment on attachment 821516 [details] [review]
Add a timeout to stop player if no text message is provided

Looks good Fernando!
Attachment #821516 - Flags: feedback?(cyang) → feedback+
Component: Gaia::Settings → Gaia::System
Assignee: nobody → frsela
(In reply to Preeti Raghunath(:Preeti) from comment #4)
> Product,
> 
> Please recommend a default timeout.

Unless Bruce wants something other than the 5 seconds suggested in comment#5, then 5 seconds should be good.
Flags: needinfo?(ffos-product) → needinfo?(bhuang)
As there is no spec definition for it, 5 seconds works.
Flags: needinfo?(bhuang)
Target Milestone: --- → 1.2 C4(Nov8)
Rebased and fixed index.html to load JS in the correct order.
(In reply to Bruce Huang (:bhuang) from comment #10)
> As there is no spec definition for it, 5 seconds works.

Bug 928582 sets 5 secs as default timeout.
https://github.com/mozilla-b2g/gaia/pull/12965/files#diff-7b4cd981b7b9c4669c33a8cecd441af2R11
Attachment #821516 - Flags: review?(kaze) → review+
Rebased and landed: https://github.com/mozilla-b2g/gaia/commit/e8139d2f325a15a3ea9e54b2ddd490d87044bb7d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Uplifted e8139d2f325a15a3ea9e54b2ddd490d87044bb7d to:
v1.2: 1a374767b276cd01d020ae1a22c4cb8b08a0f70f
You need to log in before you can comment on or make changes to this bug.