928582 - STK: No terminal response sent for PLAY_TONE and tone plays forever when missing DURATION

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Carol Yang [:cyang]]

When duration is empty (length='00') or none is sent, the tone plays forever until a button is pressed. Also, no TR is sent until a button is pressed. There should be a timeout in which tone stops playing and TR is sent.

PDU used: D014810301200082028103850652502041636B8E0104
JSON message sent: RIL:StkCommand{ commandNumber : 1, typeOfCommand : 32, commandQualifier : 0, options : { text : 'RP Ack', tone : '',  },  }

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Adding a default timeout to STK Tone player

Hi Carol,

Can you check if this patch fix the detected issue?

Thanks

Comment 2

[Carol Yang [:cyang]]

Comment on attachment 819589 [details]
Adding a default timeout to STK Tone player

Patch from attachment 819589 [details] fixes this issue.

Comment 3

[Bruce Huang [:bhuang] (inactive)]

triage: koi+ as it blocks CS

Comment 4

[Ivan Tsay (:ITsay)]

Hi Fernando,

Please help to assign one of the target milestone (1.2 C3 ~ 1.2 C4) for the bug according to your evaluation. We need the milestone flag to track when the bug will be fixed. Thank you!

Ivan

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 819589 [details]
Adding a default timeout to STK Tone player

Kaze has done the last STK reviews iirc. Let's ask him.

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Ivan Tsay (:ITsay) from comment #4)
> Hi Fernando,
> 
> Please help to assign one of the target milestone (1.2 C3 ~ 1.2 C4) for the
> bug according to your evaluation. We need the milestone flag to track when
> the bug will be fixed. Thank you!
> 
> Ivan

Done, is fixed, only waiting review. Is set to this friday, if kaze cann't review it in this short period, should be moved to next sprint.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Patch rebased

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/2b4cf9762bcd8b7657162fbf7b8f248b6676b932

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 2b4cf9762bcd8b7657162fbf7b8f248b6676b932 to:
v1.2: ce0f1753d0bf6850805612df180937314cc64534