Closed
Bug 928607
Opened 11 years ago
Closed 11 years ago
Scroll bar can not hide on latest Nightly as of 20131018
Categories
(Core :: Layout, defect)
Tracking
()
VERIFIED
FIXED
mozilla27
Tracking | Status | |
---|---|---|
firefox24 | --- | unaffected |
firefox25 | --- | unaffected |
firefox26 | --- | fixed |
firefox27 | + | verified |
b2g-v1.2 | --- | fixed |
People
(Reporter: nayinain, Assigned: roc)
References
()
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
586 bytes,
text/html
|
Details | |
2.76 KB,
patch
|
tnikkel
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131018030206
Steps to reproduce:
1. Open the test.html file
2. Click the "+" button
Actual results:
The bottom of the scroll bar appeared in the step 2.
Expected results:
Scroll bar is always hidden.
Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/423b9c30c73d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20131017030201
Bad:
http://hg.mozilla.org/mozilla-central/rev/4e7d1e2c93a6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20131018030206
Sorry for my bad English.
Comment 1•11 years ago
|
||
Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9c8ab7e9ae41
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20131017025216
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/45d9e6cd3473
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20131017030414
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9c8ab7e9ae41&tochange=45d9e6cd3473
Suspected: Bug 926706
Blocks: 926706
Status: UNCONFIRMED → NEW
tracking-firefox27:
--- → ?
Ever confirmed: true
Keywords: regression
Comment 2•11 years ago
|
||
roc - what's your read on this? I can't tell whether a large segment of the web would be impacted.
Flags: needinfo?(roc)
Assignee | ||
Comment 3•11 years ago
|
||
I'm not sure but we should definitely fix it before release.
Flags: needinfo?(roc)
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → roc
Attachment #820308 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #820308 -
Flags: review? → review?(tnikkel)
Comment 5•11 years ago
|
||
Comment on attachment 820308 [details] [diff] [review]
fix
It looks like IsCollapsed() is only relevant in the XUL case at least.
Updated•11 years ago
|
status-firefox27:
--- → affected
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
I don't think this is ready to land.
Comment 8•11 years ago
|
||
Whole push backed out since not clear what caused the reftest failures:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=ffd9c7bbd2fe&jobname=reftest
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/69d9f136cf26
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/b71812b077de
Assignee | ||
Comment 9•11 years ago
|
||
Oops.
(In reply to Timothy Nikkel (:tn) from comment #5)
> It looks like IsCollapsed() is only relevant in the XUL case at least.
What's wrong with just calling it?
Assignee | ||
Comment 10•11 years ago
|
||
BTW this caused reftest failure:
https://tbpl.mozilla.org/php/getParsedLog.php?id=29555168&tree=Mozilla-Inbound&full=1#error0
I plan to just fuzz the test on Mac. I think this is a longstanding issue where the edges of invalidated areas are sometimes off by 1/255 on Mac.
Comment 11•11 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #9)
> Oops.
>
> (In reply to Timothy Nikkel (:tn) from comment #5)
> > It looks like IsCollapsed() is only relevant in the XUL case at least.
>
> What's wrong with just calling it?
You can call it, but it looks like it should only be used here in the XUL collapsed sense, and not the table part collapsed sense.
Comment 12•11 years ago
|
||
http://www.mozilla.org/en-US/firefox/community/ page is also affected
Comment 13•11 years ago
|
||
This code blocks comes from bug 524925 where it looks like it as pulled from nsBox::SyncLayout. And that chunk of code in nsBox::SyncLayout is only executed on frames for which ComputesOwnOverflowArea() is false. And it seems that only some XUL frames have ComputesOwnOverflowArea() return false.
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #820308 -
Attachment is obsolete: true
Attachment #820308 -
Flags: review?(tnikkel)
Attachment #822364 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #822364 -
Flags: review? → review?(tnikkel)
Assignee | ||
Comment 16•11 years ago
|
||
Updated•11 years ago
|
Attachment #822364 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 17•11 years ago
|
||
Updated•11 years ago
|
status-firefox24:
--- → unaffected
status-firefox25:
--- → unaffected
status-firefox26:
--- → unaffected
OS: Windows 7 → All
Hardware: x86_64 → All
Comment 19•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Comment 20•11 years ago
|
||
Looks good to me. Build ID: 20131028040205
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment 21•11 years ago
|
||
Tested http://www.mozilla.org/en-US/contribute/ and the testcase.
Comment 22•11 years ago
|
||
Comment on attachment 822364 [details] [diff] [review]
fix v2
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: column flicker - bug 917060
Testing completed (on m-c, etc.): on m-c since 2013-10-26, also in Aurora(27)
Risk to taking this patch (and alternatives if risky): low risk
String or IDL/UUID changes made by this patch: none
Landing bug 926706 and bug 928607 on Beta(26) to fix/wallpaper bug 917060
should be straightforward and lower risk than backing out what caused that bug.
Attachment #822364 -
Flags: approval-mozilla-beta?
Updated•11 years ago
|
Attachment #822364 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 23•11 years ago
|
||
changing 26 to 'affected' since we'll be landing this there and it shouldn't state 'unaffected'
Comment 24•11 years ago
|
||
Flags: in-testsuite+
Comment 25•11 years ago
|
||
Updated•11 years ago
|
status-b2g-v1.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•