Closed
Bug 928616
Opened 11 years ago
Closed 11 years ago
Clean up JS_CopyPropert{ies,y}From Implementation
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bholley, Assigned: bholley)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
6.95 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
These are followup tasks from bug 911864 comment 39. We want to do two things: (1) Stop using shapes, and rewrite things in terms of property descriptors. (2) skip copying JSPropertyOp-implemented properties.
Assignee | ||
Comment 1•11 years ago
|
||
(3) - Add a MOZ_RELEASEMODE_ASSERT to mfbt and use it when checking invariants in these functions.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #831918 -
Flags: review?(jorendorff)
Assignee | ||
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5dc219cf73fd
Comment 4•11 years ago
|
||
Comment on attachment 831918 [details] [diff] [review] Clean up JS_CopyPropertiesFrom. v1 Review of attachment 831918 [details] [diff] [review]: ----------------------------------------------------------------- That's great. Thank you. ::: js/src/jsobj.cpp @@ +1739,5 @@ > + JSAutoCompartment ac(cx, target); > + RootedId wrappedId(cx, id); > + if (!cx->compartment()->wrap(cx, &desc) || > + !cx->compartment()->wrapId(cx, wrappedId.address())) > + return false; Style nit: Needs curly braces around `return false;`, each on its own line. But I usually if (!pleaseWork()) return false; if (!pleaseDontFail()) return false;
Attachment #831918 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Green try run in comment 3. https://hg.mozilla.org/integration/mozilla-inbound/rev/73cfaa3c248f
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/73cfaa3c248f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•