928765 - Create MediaDecoderReader::GetBuffered() base implementation that estimates buffered ranges

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Every MediaDecoderReader backend that has to estimate the buffered ranges using GetEstimatedBufferedTimeRanges() ends up reimplementing the same stub to call GetEstimatedBufferedTimeRanges().

We can instead implement this stub in MediaDecoderReader::GetBuffered(). Backends that can make a more accurate buffered ranges calculation override GetBuffered() as usual, and those that can't don't need to re-implement the code that calls GetEstimatedBufferedTimeRanges().

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Patch.

The only behaviour change here is in MediaPluginReader::GetBuffered(), where we use the duration as per the MediaDecoder rather than as per the plugin, but I think that that's not actually a behaviour change, since the decoder should have received the duration from the plugin anyway?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/23c23b472a4f

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23c23b472a4f