928782 - B2G RIL: "Import SIM Contact" failed after when Contact API is WebIDLized.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

STR:
Insert some SIM with some SIM contacts on it.

Contact App -> Settings -> Import Contacts -> SIM card

Now we got the following message.

10-21 11:31:42.294: E/GeckoConsole(704): [JavaScript Error: "'toJSON' called on an object that does not implement interface mozContact." {file: "jar:file:///system/b2g/omni.ja!/components/RILContentHelper.js" line: 1467}]

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll check if it's something wrong from RIL first.
And discuss the correct way to fix this with Reuben.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Sorry I forgot to mention I have enabled the DEBUG_ALL flag in dom/system/gonk/ril_consts.js. 
If I set it to false, now the Gaia part will meet this error.

10-21 14:55:02.601: E/GeckoConsole(1408): [JavaScript Error: "TypeError: Argument 1 of ContactManager.save does not implement interface mozContact." {file: "app://communications.gaiamobile.org/contacts/js/utilities/import_sim_contacts.js" line: 184}]

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Now I try to remove the ObjectWrapper added from Bug 842981, now Gaia got some error.

10-21 15:36:34.602: E/GeckoConsole(1898): [JavaScript Error: "TypeError: Value being assigned to ContactField.type is not an object." {file: "app://communications.gaiamobile.org/contacts/js/utilities/import_sim_contacts.js" line: 153}]

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Doing Comment 3 also removes the error from Comment 2.
So now the error is in Comment 3 whether the DEBUG is on or off in RILContentHelper.js

Comment 5

[Reuben Morais [:reuben]]

Yes, this is incorrect usage of the mozContact interface. Comment 2 means you're trying to do something like |navigator.mozContacts.save({name: ["foo"]});| or whatever. You have to create a mozContact object first:

  var c = new mozContact({name: ["foo"]});
  navigator.mozContacts.save(c);

Comment 3 means you're trying to set .type to something that's incompatible with the interface (it needs to be an array of strings).

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

rebase

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v3

Seems somebody commited before me, rebase again

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eb3cc0b4cc43

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eb3cc0b4cc43