Closed Bug 928875 Opened 9 years ago Closed 9 years ago

import contacts from google broken due to webidl

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

(Whiteboard: [c= p=1 s= u=])

Attachments

(1 file)

It looks like webidl also broke then import from google:

E/GeckoConsole( 1837): [JavaScript Error: "TypeError: 'type' member of ContactFieldInit can't be converted to a sequence." {file: "app://communications.gaiamobile.org/contacts/js/contacts_importer.js" line: 51}]
Fix more webidl breakage by using arrays more strictly where needed and passing actual mozContact object to mozContacts.save() function.
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Attachment #819678 - Flags: review?(francisco.jordano)
Whiteboard: [c= p=1 s= u=]
Comment on attachment 819678 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12972

Looking a safe change to me.

Please merge once the test-agent pass on travis.

Thanks!
Attachment #819678 - Flags: review?(francisco.jordano) → review+
Blocks: 928890
Unfortunately the ftp site is offline so travis can't download firefox.  I ran the tests locally instead and this did not introduce any failure.

Merged:

  https://github.com/mozilla-b2g/gaia/commit/f9a58ebc7e98ece75b6406992dd710b513aae0a1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reopening this to remind myself to re-enable the test.  I don't want to re-enable till all pending pull requests related to bug 850430 land.  There is too much in flight at the moment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [c= p=1 s= u=] → [c= p=1 s= u=][xfail]
Actually, this was one I found on device, not in the gaia-ui-tests.  Getting a bit turned around with all the bustage and fixes.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [c= p=1 s= u=][xfail] → [c= p=1 s= u=]
You need to log in before you can comment on or make changes to this bug.