928875 - import contacts from google broken due to webidl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

It looks like webidl also broke then import from google:

E/GeckoConsole( 1837): [JavaScript Error: "TypeError: 'type' member of ContactFieldInit can't be converted to a sequence." {file: "app://communications.gaiamobile.org/contacts/js/contacts_importer.js" line: 51}]

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/12972

Fix more webidl breakage by using arrays more strictly where needed and passing actual mozContact object to mozContacts.save() function.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 819678 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12972

Looking a safe change to me.

Please merge once the test-agent pass on travis.

Thanks!

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Unfortunately the ftp site is offline so travis can't download firefox.  I ran the tests locally instead and this did not introduce any failure.

Merged:

  https://github.com/mozilla-b2g/gaia/commit/f9a58ebc7e98ece75b6406992dd710b513aae0a1

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Reopening this to remind myself to re-enable the test.  I don't want to re-enable till all pending pull requests related to bug 850430 land.  There is too much in flight at the moment.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Actually, this was one I found on device, not in the gaia-ui-tests.  Getting a bit turned around with all the bustage and fixes.