generate_diff.py should use mozfile.rmtree() for tempfile cleanup to reduce flakiness on Windows

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: emorley, Unassigned)

Tracking

Trunk
x86_64
Windows 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

During cleanup at the end of generate_diff.py we attempt to remove temp files using shutil.rmtree():
http://hg.mozilla.org/mozilla-central/file/23c23b472a4f/testing/mozbase/generate_diff.py#l385

This doesn't work well on Windows (bug 926415 comment 0), so we should try using mozfile.rmtree() to see if it helps fix the problem.
(In reply to Ed Morley (Mostly away until 21st October) [:edmorley UTC+1] from comment #0)
> During cleanup at the end of generate_diff.py we attempt to remove temp
> files using shutil.rmtree():
> http://hg.mozilla.org/mozilla-central/file/23c23b472a4f/testing/mozbase/
> generate_diff.py#l385
> 
> This doesn't work well on Windows (bug 926415 comment 0), so we should try
> using mozfile.rmtree() to see if it helps fix the problem.

So I don't think we want generate_diff.py to depend on mozbase, as that's just going to complicate using the script. I'd rather see a fix that just did something like what's described here:

http://stackoverflow.com/questions/1213706/what-user-do-python-scripts-run-as-in-windows/1214935#1214935
Yeah that's true - and that stackoverflow tip looks promising, thank you :-)
Assignee: nobody → emorley
generate_diff.py no longer exists after bug 949600.
Assignee: emorley → nobody
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.