928968 - Add a command to the gaia command line tool to print the applications installed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Johannes Vogel (:nebelhom)]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130911164256

Steps to reproduce:

I think it would be a very useful feature to add a command in gcli that lists all the applications installed.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I already have a patch that does this (it was useful for investigating an issue), but think we should probably wait for the outcome of bug 921939 before proceeding. Ideally we could add a command to gaiatest that then allows other tools to output this list, such as b2gperf to help someone discover the available applications.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

Pointer to Github pull-request

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8343042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

This patch adds an installed_apps property to GaiaApps and a listallapps command to gcli. Also modified the runningApps method to be a property and return a list of GaiaApp objects. I have updated all places this method is called, and checked that it's not used in any package (that I'm aware of) that depends on gaiatest.

Output looks like:

$ gcli listallapps
1: Browser
2: Calendar
3: Camera
...

$ gcli listrunningapps
1: Homescreen
2: Messages
3: Phone
...

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8343042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

Rob: This patch includes a change to an endurance test. I've tested it successfully locally, but would appreciate your review. Thanks.

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8343042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

Looks great, thanks for updating the endurance test Dave, appreciated.

Comment 6

[Johannes Vogel (:nebelhom)]

:davehunt

Having looked over the code, it looks fine to me. I can't find anything, but Travis-Ci is unhappy though...

(In reply to Dave Hunt (:davehunt) from comment #3)
> Comment on attachment 8343042 [details]
> Pointer to Github pull request:
> https://github.com/mozilla-b2g/gaia/pull/14402
> 
> This patch adds an installed_apps property to GaiaApps and a listallapps
> command to gcli. Also modified the runningApps method to be a property and
> return a list of GaiaApp objects. I have updated all places this method is
> called, and checked that it's not used in any package (that I'm aware of)
> that depends on gaiatest.
> 
> Output looks like:
> 
> $ gcli listallapps
> 1: Browser
> 2: Calendar
> 3: Camera
> ...
> 
> $ gcli listrunningapps
> 1: Homescreen
> 2: Messages
> 3: Phone
> ...

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Johannes Vogel (:nebelhom) from comment #6)
> Having looked over the code, it looks fine to me. I can't find anything, but
> Travis-CI is unhappy though...

The Travis-CI failure is a known intermittent. I've retriggered it but this failure doesn't concern me for this patch.

Comment 8

[Zac C (:zac)]

Comment on attachment 8343042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

r+ this could be useful in the future, thanks.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8343042 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14402

Johannes gave feedback in comment 6.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/76f5300fda681599d8ac8e91996ecc19c82225a6 (master)
https://github.com/mozilla-b2g/gaia/commit/310d0b5629bd4d86d7f97334e0c84222ceb29cdf (v1.2)