Update Shumway to version 0.7.501

RESOLVED FIXED in Firefox 27

Status

Firefox Graveyard
Shumway
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: yury, Assigned: yury)

Tracking

27 Branch
Firefox 27
Dependency tree / graph

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 819763 [details] [diff] [review]
shumway_7_501.diff
Attachment #819763 - Flags: review?(till)
(Assignee)

Comment 2

4 years ago
Forgot change log:
#747 Fixes regression in #737
#748 Makes construction of pre-render clip mask optional
#750 Small optimizations.
#763 target argument of MovieClipLoader#loadClip and unloadClip may be level
#768 Builds minimal playerglobal.abc
#775 Remove Kanvas for now
#781 Update README.md
#789 Misc timeline fixes and refactoring
#792 Reduce stack-length changes in interpreter main loop by changing top in-place
#794 Fixes _xscale and _yscale in AVM1.
#795 AVM2 interpreter and utils optimizations
#797 Fixes regression in #789
#798 Fixes rounded rectangles
#802 Correctness-fixes in dealing with incorrect scripts
#804 Support Flex-embedded images
#806 JSON fixes and makes GIRP sort of work.
#810 TextField fixes and support for additional properties
#811 Fixes bounding calculation
#813 Set Loader URL from URLRequest.
#814 Ignoring UTF8 errors
#815 Fixes regression in #811
#816 Adds support for non-smoothed Bitmaps
#817 Fix regression causing BitmapData#draw to throw an exception
#818 Fixes and optimizes mouse events
#821 Initial telemetry probes
#823 Fixes parsing of button characters
#824 Fixes regression in #789
#825 Add fallback to telemetry
#827 Improves url parsing on the extension side
#828 TextField fixes, plus non-smoothed bitmap fills
#830 Fixes pixel snapping
#831 Change JSHint config to allow line breaks before ? in ternary op expressions
#832 Enum Fixes / Cleanup
#833 Refactoring ShumwayStreamConverter (see bug 924571)
#837 Moar TextField goodness
#838 Load clip fixes for AVM1
#839 Fix handling of font set via TextField#defaultTextFormat
#840 Resolves AVM1 scope variable
#842 Misc AVM1 fixes
#843 Speeds up blend mode resolution
#845 Improve metrics precision
Comment on attachment 819763 [details] [diff] [review]
shumway_7_501.diff

Review of attachment 819763 [details] [diff] [review]:
-----------------------------------------------------------------

The changes outside of shumway.js and shumway-worker.js look good to me. I obviously haven't looked through those two.

However, I'd like for this to be two patches: one that introduces the Telemetry support (so the changes in the .jsm files and avm-sandbox.js) and one that contains the shumway-internal changes. The latter you can land with r=me, the former I'm not really qualified to review. You probably know who should review that. If not, I bet bsmedberg knows.
Attachment #819763 - Flags: review?(till)
(Assignee)

Comment 4

4 years ago
Created attachment 819782 [details] [diff] [review]
Telemetry for Shumway (1/2)
Attachment #819782 - Flags: review?(till)
(Assignee)

Comment 5

4 years ago
Created attachment 819783 [details] [diff] [review]
Update to version 0.7.501 (2/2)

Update to version 0.7.501
Attachment #819763 - Attachment is obsolete: true
Attachment #819783 - Flags: review?(till)
(Assignee)

Updated

4 years ago
Attachment #819782 - Attachment description: Telemetry to Shumway → Telemetry for Shumway (1/2)
(Assignee)

Updated

4 years ago
Attachment #819783 - Attachment description: bug928969-2.diff → Update to version 0.7.501 (2/2)
Comment on attachment 819782 [details] [diff] [review]
Telemetry for Shumway (1/2)

Review of attachment 819782 [details] [diff] [review]:
-----------------------------------------------------------------

That's exactly what I meant - thank you!
Attachment #819782 - Flags: review?(till) → review+
Comment on attachment 819783 [details] [diff] [review]
Update to version 0.7.501 (2/2)

Review of attachment 819783 [details] [diff] [review]:
-----------------------------------------------------------------

nice
Attachment #819783 - Flags: review?(till) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7026e79fae
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7a457cfcaa9a
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8d7026e79fae
https://hg.mozilla.org/mozilla-central/rev/7a457cfcaa9a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
(Assignee)

Updated

4 years ago
Blocks: 943006
(Assignee)

Updated

3 years ago
Blocks: 958110
(Assignee)

Updated

3 years ago
No longer blocks: 958110
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.