[a10n] With the death of PushJS, .date is ['date']

RESOLVED FIXED

Status

Localization Infrastructure and Tools
Automation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Pike, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 819849 [details] [diff] [review]
use ['date'] instead of .date

In elmo, we had PushJS, which was mapping a bunch of push dictionary [] foo to .foo. In particular, .date.

This patch makes that use actual dictionaries again.

Rob, does this look reasonable? Didn't make it go through a local staging run yet, but it seems pretty straightforward.
Attachment #819849 - Flags: review?(rhelmer)
Comment on attachment 819849 [details] [diff] [review]
use ['date'] instead of .date

Testing it on the a10n server now, this does look correct to me!
Attachment #819849 - Flags: review?(rhelmer) → review+
(Reporter)

Comment 2

5 years ago
Thanks, landed https://github.com/Pike/a10n/commit/6dea6080d4f8c389c44b7c5aec6a5ffce9017868, marking FIXED.

Sorry for the trouble.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

4 years ago
tools tsunami, sorry.
Component: Infrastructure → Automation
Product: Mozilla Localizations → Localization Infrastructure and Tools
You need to log in before you can comment on or make changes to this bug.