Closed
Bug 929140
Opened 12 years ago
Closed 12 years ago
add a jwplayer script loaded to a pro account key via a config option
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
bug 929131 allows the jwplayer wrapper to use whatever is already there if it detects something.
Now we just need to put something there, which should live in a config.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
I am sending you the key.
Attachment #819974 -
Flags: review?(schranz.m)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 819974 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/281
R+ with nit.
Attachment #819974 -
Flags: review?(schranz.m) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Cool, I think we'll land this tomorrow some time, on staging at least.
Going to add jbuck here so I don't forget, but I may need his help getting the jwplayer api key added to configs on staging and/or prod.
Flags: needinfo?(jon)
|
||
Comment 4•12 years ago
|
||
Yes, you will need myself, cade or jp to add credentials *before* you push to staging
Flags: needinfo?(jon)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/0082bb52250f2013ec612de38eb85113e6bb7d8a
Needs verification.
The key you see in the commit is the fallback, free version.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in
before you can comment on or make changes to this bug.
Description
•