bug 929131 allows the jwplayer wrapper to use whatever is already there if it detects something. Now we just need to put something there, which should live in a config.
Created attachment 819974 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/281 I am sending you the key.
Attachment #819974 - Flags: review?(schranz.m)
Comment on attachment 819974 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/281 R+ with nit.
Attachment #819974 - Flags: review?(schranz.m) → review+
Cool, I think we'll land this tomorrow some time, on staging at least. Going to add jbuck here so I don't forget, but I may need his help getting the jwplayer api key added to configs on staging and/or prod.
Yes, you will need myself, cade or jp to add credentials *before* you push to staging
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/0082bb52250f2013ec612de38eb85113e6bb7d8a Needs verification. The key you see in the commit is the fallback, free version.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.