Closed Bug 929247 Opened 8 years ago Closed 7 years ago

[B2G][1.2][Lockscreen] "Emergency Call" text in several languages are not center justified on the PIN pad button resulting in text spilling into the "0" button.

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S3 (14mar)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: laliaga, Assigned: flod)

References

Details

(Whiteboard: LocRun1.2, LocRun1.3)

Attachments

(3 files)

With Security PIN enabled, Dutch, Russian, Slovak, BR Portuguese, Hungarian, Spanish, and Catalan all have "Emergency Call" text overrun into the "0" button. This is either due to long translations, the text isn't center justified on the button, or both.

Repro Steps:
1. Flash to Buri aurora 20131021004006.
2. Set language to any of the languages listed in the description.
3. Set Security PIN for the lockscreen.
4. View the lockscreen.

Actual Results:
"Emergency Call" text on the bottom left PIN pad button runs out of the button boundaries. Text is not center justified.

Expected Results:
Text to be center justified and/or translations shortened.

Attached Screenshot:
Emergency Call Text Russian.png

Environmental Variables:
Gaia   1fd315337d8ae891c3024e4c682c4c50797ea40e
SourceStamp d585fe28cd55
BuildID 20131021004006
Version 26.0a2
Whiteboard: LocRun1.2
Flagging UX as this seems to happen in at least 7 of our 1.2 shipping locales
Flags: needinfo?(firefoxos-ux-bugzilla)
Flagging Eric for an adjustment.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(epang)
(In reply to Stephany Wilkes from comment #2)
> Flagging Eric for an adjustment.

let's try reducing the font size by 1-2pt.  If the string still does not fit, please let me know.  Thanks!
Flags: needinfo?(epang)
Whiteboard: LocRun1.2 → LocRun1.2, LocRun1.3
Not sure who should have tried this, but I'll take a look

Reference string
http://transvision.mozfr.org/string/?entity=apps/system/system.properties:emergency-call-button&repo=gaia_1_3

From a quick look, Russian could not be our first problem.
Attached file Pull request on Github
Attachment #8386650 - Flags: review?(21)
Not sure if we need UX feedback too.
Assignee: nobody → francesco.lodolo
Comment on attachment 8386650 [details] [review]
Pull request on Github

Since I'm not working on Lockscreen for a long time, Greg is the better reviewer than me.
Attachment #8386650 - Flags: review?(yurenju.mozilla) → review?(gweng)
Comment on attachment 8386650 [details] [review]
Pull request on Github

Review granted since it fixed the problem and passed all tests.
Attachment #8386650 - Flags: review?(gweng) → review+
Keywords: checkin-needed
Master: 27ccb8e96a18915ac1bc0c86047ceb451745537a
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
Duplicate of this bug: 858754
Duplicate of this bug: 880905
You need to log in before you can comment on or make changes to this bug.