929247 - [B2G][1.2][Lockscreen] "Emergency Call" text in several languages are not center justified on the PIN pad button resulting in text spilling into the "0" button.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Lucas Aliaga]

Attachment: Emergency Call Text Russian.png

With Security PIN enabled, Dutch, Russian, Slovak, BR Portuguese, Hungarian, Spanish, and Catalan all have "Emergency Call" text overrun into the "0" button. This is either due to long translations, the text isn't center justified on the button, or both.

Repro Steps:
1. Flash to Buri aurora 20131021004006.
2. Set language to any of the languages listed in the description.
3. Set Security PIN for the lockscreen.
4. View the lockscreen.

Actual Results:
"Emergency Call" text on the bottom left PIN pad button runs out of the button boundaries. Text is not center justified.

Expected Results:
Text to be center justified and/or translations shortened.

Attached Screenshot:
Emergency Call Text Russian.png

Environmental Variables:
Gaia   1fd315337d8ae891c3024e4c682c4c50797ea40e
SourceStamp d585fe28cd55
BuildID 20131021004006
Version 26.0a2

Comment 1

[Delphine Lebédel]

Flagging UX as this seems to happen in at least 7 of our 1.2 shipping locales

Comment 2

[Stephany Wilkes]

Flagging Eric for an adjustment.

Comment 3

[Eric Pang [:epang] UX]

(In reply to Stephany Wilkes from comment #2)
> Flagging Eric for an adjustment.

let's try reducing the font size by 1-2pt.  If the string still does not fit, please let me know.  Thanks!

Comment 4

[Francesco Lodolo [:flod]]

Not sure who should have tried this, but I'll take a look

Reference string
http://transvision.mozfr.org/string/?entity=apps/system/system.properties:emergency-call-button&repo=gaia_1_3

From a quick look, Russian could not be our first problem.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 6

[Francesco Lodolo [:flod]]

Attachment: Screenshots of several locales with patch applied

Not sure if we need UX feedback too.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8386650 [details] [review]
Pull request on Github

Since I'm not working on Lockscreen for a long time, Greg is the better reviewer than me.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8386650 [details] [review]
Pull request on Github

Review granted since it fixed the problem and passed all tests.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: 27ccb8e96a18915ac1bc0c86047ceb451745537a