929264 - archive.org link doesn't seem to work on embed

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

This is archive or jwplayer or both, but this link: https://archive.org/details/COMW_20131014_160000_The_Daily_Show_With_Jon_Stewart#start/59/end/89

Plays in the editor and not in the embed. Consistently.

Comment 1

[Matthew Schranz [:mjschranz]]

Are you sure this has nothing to do with jwplayer? I went and checked out https://github.com/mozilla/popcorn.webmaker.org/commit/b6b7533cd2ff6172aaabae3ef3765da9a8587c08 and used that as a source and it played just fine in Chrome, whereas on master right now I had issues with it player in Chrome.

Comment 2

[Scott [:thecount] Downe]

No, not sure, but about to figure that out.

Could be either, or a combination of both. Either way, it works in the editor, so whatever the difference is, is what the embed should also do, so pretty sure it is fixable.

Comment 3

[Scott [:thecount] Downe]

Turns out the url that's being passed into the embed is escaped: https://archive.org/download/COMW_20131014_160000_The_Daily_Show_With_Jon_Stewart/COMW_20131014_160000_The_Daily_Show_With_Jon_Stewart.mp4?cs=1&exact=1&start=59&end=89&butteruid=1382413862544

Has this always been an issue? or did something change?

Comment 4

[Scott [:thecount] Downe]

Nope, not it.

Comment 5

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/284

Comment 6

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn-js/pull/354

Both fixes are needed for a fixed experience on both chrome and FF.

Comment 7

[Scott [:thecount] Downe]

So, turns out it was the encoded url, we just so happen to decode through a text generated source element, however, using that method won't give us proper error events, so we bypass it in popcorn.smart.

So once we're in the bypass path, we can get errors, which we need to detect to know if we want to setup jwplayer or not, we end up with a url that still needs to be decoded.

One source means we throw errors so jwplayer can be attempted, multiple sources means we us fallbacks and not jwplayer, for now anyway. We can probably get away with removing fallbacks, but there are considerations there I don't think we've thought through yet.

Comment 8

[Matthew Schranz [:mjschranz]]

Comment on attachment 820135 [details] [review]
https://github.com/mozilla/popcorn-js/pull/354

R+ with nits.

Comment 9

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/62c682f9496f3d870aa7b5a9f65d3d33d955931a
Staged: https://github.com/mozilla/popcorn-js/commit/b645bf1ebc1348cedca5315cebdba18e8fe6ea7a

Needs verification.