929274 - InvalidStateError when accessing transaction.error after aborted transaction

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[spamdaemon]

Attachment: transactionTest.js

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 2013091200

Steps to reproduce:

1. Create a store
2. Add an element with a key, e.g. "FOO"
3. Create a transaction, call it tx
4. Add the element again with the same key to trigger a duplicate error
5. Access tx.error in the transaction's onerror handler


Actual results:

[20:46:45.468] InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable @ https://localhost:8080/transactionTest.js:20



Expected results:

I'm not sure what to expect, but I did not expect an exception to be raised in this case.
Chrome simply reports tx.error===null, but I'm thinking that some kind of DOM error should be produced.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This does indeed look like we're not following the spec. According to my reading we should return null as long as the transaction is open, and should *never* let it throw an exception.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: changes.patch

I think this is better.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

With a better test.

Comment 4

[Jan Varga [:janv]]

Comment on attachment 820267 [details] [diff] [review]
Patch, v1

Review of attachment 820267 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, no nits :)

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/b2g-inbound/rev/8e3b6d7159c2

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Crap, something is failing now... https://tbpl.mozilla.org/php/getParsedLog.php?id=30567897&tree=B2g-Inbound

Backed out:
  https://hg.mozilla.org/integration/b2g-inbound/rev/6ee4a3c3c597

Comment 7

[Shihua Zheng]

Attachment: Patch, v2

Here is a new patch. Passed unit tests locally.

Comment 8

[Shihua Zheng]

Attachment: Patch v3

Updated patch.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8424187 [details] [diff] [review]
Patch v3

Review of attachment 8424187 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying jan's review forward, test changes look good to me!

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Shihua, did you get this pushed to try? Can you paste the link to the tbpl run here? Thanks!

Comment 11

[Shihua Zheng]

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #10)
> Shihua, did you get this pushed to try? Can you paste the link to the tbpl
> run here? Thanks!

https://tbpl.mozilla.org/?tree=Try&rev=a2f13887b7b4

Comment 12

[Shihua Zheng]

Attachment: Patch v4

Disable mochitest for b2g desktop.
Try run: https://tbpl.mozilla.org/?tree=Try&rev=8c9f26a8cea4

Comment 13

[Shihua Zheng]

Try run passed. Need checkin?

Comment 14

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e5b0502f93

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4e5b0502f93