929285 - [Gaia][System] after enable software home button and rebooting, app cannot be launched

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Try on recent build 20131020040204 and flashed to latest gaia 595ee85a2d7f16b7.

1. device enable the software home button and reboot it
2. click one of the app

Expect: launch the app -- KO
Actual: App icon enlarged and disappear, but screen only remain the background of homescreen

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

I guess it may come from system app, so I tried to go back to 5a185523e3 and make reset-gaia, and found out it works normally.
And also tried 6238e6f957, and it breaks. So, it's properly a regression between these two commit.

https://github.com/mozilla-b2g/gaia/commits/master/apps/system

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: 929285.patch

Root cause: miss predefine appWindow size for software home button enabled.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/cf2e63a44fbf095d3a7b5975919a1df19f610c8f

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+'ing because this bug is going to break phones w/o hardware home buttons, e.g. Nexus.

The patch is fairly simple too so if we cannot koi+ this I could a+ the patch instead.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 cf2e63a44fbf095d3a7b5975919a1df19f610c8f
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted cf2e63a44fbf095d3a7b5975919a1df19f610c8f to:
v1.2: a87e04237d9fc1b26c70cf2baa72412250fb26d7

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

clear ni