929398 - --disable-webm build fails with "dist/include/OggReader.h:14:26: fatal error: vorbis/codec.h: No such file or directory" from DecoderTraits.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

I can't build with these .mozconfig options:
{
ac_add_options --enable-debug --disable-optimize
ac_add_options --disable-webm
}

My build fails partway through, with this error:
{
/mozilla-central/content/media/DecoderTraits.cpp:18:0:
../../dist/include/OggReader.h:14:26: fatal error: vorbis/codec.h: No such file or directory
  #include <vorbis/codec.h>
                           ^
}

This is the converse of bug 928530 (which is about a build failure with --disable-ogg).  *That* bug makes a little more sense (sure, our webm code requires ogg support in order to build), but this bug here makes less sense (...does our ogg code really require webm support in order to build?)

Comment 1

[Daniel Holbert [:dholbert]]

(This is with GCC 4.8 on Ubuntu 13.10, though it's unlikely that matters.)

Comment 2

[Ralph Giles (:rillian)]

webm requires vorbis which requires ogg except on arm. I'll add an error for this as part of bug 928530.

Comment 3

[Ralph Giles (:rillian)]

Attachment: Enable vorbis if either ogg or webm are enabled

This should fix the ogg-depending-on-webm issue. The problem was we were only enabling the vorbis codec based on the webm switch, not on the ogg switch. This patch enables it based on either.

Comment 4

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fde59e2a706

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1fde59e2a706