929404 - Build error with --disable-opus --enable-warnings-as-errors: OggCodecState.cpp:65:16: error: ‘int16_t mozilla::LEInt16(const unsigned char*)’ defined but not used [-Werror=unused-function]

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Daniel Holbert [:dholbert]]

I can't build with these .mozconfig options...
{
ac_add_options --enable-debug --disable-optimize
ac_add_options --disable-opus
ac_add_options --enable-warnings-as-errors
}

...due to this build warning (treated as an error), for an unused opus-specific function that we unconditionally define but only use in #ifdef-opus code:
{
media/ogg/OggCodecState.cpp:65:16: error: ‘int16_t mozilla::LEInt16(const unsigned char*)’ defined but not used [-Werror=unused-function]
}

Comment 1

[Daniel Holbert [:dholbert]]

If we define the function as inline instead of static, the warning (error) goes away. Given that this is a one-liner anyway, it seems like a reasonable function to inline.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 820265 [details] [diff] [review]
fix v1

Derf, feel free/encouraged to steal this review if you get to it before kinetik. :)

(If you prefer, I'm happy to add #ifdef wrappers around this function, instead of 'inline'.  'inline' just seemed cleaner & it's nicer if we want to call it in other parts of this file as well.)

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a2fa71f2657

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a2fa71f2657