Closed Bug 929414 Opened 6 years ago Closed 6 years ago

Fix small bug in MacroAssembler::extractTag

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patch.patchSplinter Review
extractTag with TypedOrValueRegister uses:

    mov(ImmWord(ValueTypeFromMIRType(reg.type())), scratch);

But the JSValueType is a value between 0 and 7. What we want is MIRTypeToTag to get the tag (like 0xffffff8x on x86).

This improves the Clojurescript "[] (list 1 2 3)" test from 540 to 269 ms. Without this patch, SetPropertyIC's guardTypeSet always fails if the value is typed.
Attachment #820269 - Flags: review?(hv1989)
Comment on attachment 820269 [details] [diff] [review]
patch.patch

Review of attachment 820269 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #820269 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/7f3af7b5ab29
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.