Closed Bug 929427 Opened 7 years ago Closed 6 years ago

Compilation fails with --disable-opus, in webrtc code, with "opus_interface.c:16:18: fatal error: opus.h: No such file or directory"

Categories

(Core :: WebRTC, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Unassigned)

References

Details

STR:
Build with
 ac_add_options --disable-opus
in your mozconfig.

RESULTS:
Build error when your build reaches webrtc:
{
media/webrtc/trunk/webrtc/modules/audio_coding/codecs/opus/opus_interface.c:16:18: fatal error: opus.h: No such file or directory
}

Presumably you can hack around this by also including --disable-webrtc, but that's non-obvious (until you've wasted time on a failed build).

Maybe webrc should require opus? If so, we need to enforce this in configure (either with an immediate failure or with a "let me also disable this for you" config-tweak), per bug 928530 comment 4.
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Maybe webrc should require opus? If so, we need to enforce this in configure

...or, if it's possible for our webrtc code to simply respect the "--disable-opus", then that'd be even better.
Component: Video/Audio → WebRTC
(I'm building on Ubuntu 13.10 with GCC 4.8)
Looks like rillian's fixing this over in bug 928530 (in the last chunk of attachment 820420 [details] [diff] [review]). Adding dependency.
Depends on: 928530
(In reply to Daniel Holbert [:dholbert] from comment #1)
> ...or, if it's possible for our webrtc code to simply respect the
> "--disable-opus", then that'd be even better.

It's possible, but Opus is mandatory-to-implement for WebRTC, so I don't think it's a good idea.
Webrtc-without-opus build configs should error out immediately then. (and they will with rillian's patch on bug 928530; woot!)
Depends on: 1100632
This is resolved by bug 1100632.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.