929427 - Compilation fails with --disable-opus, in webrtc code, with "opus_interface.c:16:18: fatal error: opus.h: No such file or directory"

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
Build with
 ac_add_options --disable-opus
in your mozconfig.

RESULTS:
Build error when your build reaches webrtc:
{
media/webrtc/trunk/webrtc/modules/audio_coding/codecs/opus/opus_interface.c:16:18: fatal error: opus.h: No such file or directory
}

Presumably you can hack around this by also including --disable-webrtc, but that's non-obvious (until you've wasted time on a failed build).

Maybe webrc should require opus? If so, we need to enforce this in configure (either with an immediate failure or with a "let me also disable this for you" config-tweak), per bug 928530 comment 4.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Maybe webrc should require opus? If so, we need to enforce this in configure

...or, if it's possible for our webrtc code to simply respect the "--disable-opus", then that'd be even better.

Comment 2

[Daniel Holbert [:dholbert]]

(I'm building on Ubuntu 13.10 with GCC 4.8)

Comment 3

[Daniel Holbert [:dholbert]]

Looks like rillian's fixing this over in bug 928530 (in the last chunk of attachment 820420 [details] [diff] [review]). Adding dependency.

Comment 4

[Timothy B. Terriberry (:derf)]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> ...or, if it's possible for our webrtc code to simply respect the
> "--disable-opus", then that'd be even better.

It's possible, but Opus is mandatory-to-implement for WebRTC, so I don't think it's a good idea.

Comment 5

[Daniel Holbert [:dholbert]]

Webrtc-without-opus build configs should error out immediately then. (and they will with rillian's patch on bug 928530; woot!)

Comment 6

[Ralph Giles (:rillian)]

This is resolved by bug 1100632.