[e.me][bug] Unrelated installed apps appear in Collections

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ranbena, Assigned: amirn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is an internal E.me issue.

STR:
1. Create a Collection named "whatsapp".
2. Search for "whatsapp"
3. From marketplace suggestions, install "loqui"

Expected:
Loqui does not appear in "whatsapp" Collection.

Actual:
Loqui appears in "whatsapp" Collection.

Technical:
Installed apps are added to Collections by tags and experiences instead of by experiences only.
(Reporter)

Updated

5 years ago
Assignee: nobody → amirn
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 822906 [details]
redirect to PR 13120.html
Attachment #822906 - Flags: review?(ran)
Comment on attachment 822906 [details]
redirect to PR 13120.html

Not exactly what I meant. Search should use tagsQueryIndex and Collection should use expQueryIndex.
Attachment #822906 - Flags: review?(ran) → review-
(Assignee)

Comment 3

5 years ago
Updated PR:
* separate Tags from Experiences in QueryIndex
* tags are used for Search results
* experiences are used for Collections
(Assignee)

Updated

5 years ago
Blocks: 919555
Noticed a dedup bug:
Installing an app will make the marketplace suggestion and the installed app disappear from above the line.
(Assignee)

Comment 5

5 years ago
(In reply to Ran Ben Aharon (Everything.me) from comment #4)
> Noticed a dedup bug:
> Installing an app will make the marketplace suggestion and the installed app
> disappear from above the line.

fixed and updated PR.
I still see it happening.

STR:
1. Search "whatsapp"
2. Install the 2 apps suggested.
3. Return to "whatsapp" search.

Actual: Installed apps do not appear.
Expected: Well, you know
Flags: needinfo?(amirn)
(Assignee)

Comment 7

5 years ago
(In reply to Ran Ben Aharon (Everything.me) from comment #6)
> I still see it happening.
> 
> STR:
> 1. Search "whatsapp"
> 2. Install the 2 apps suggested.
> 3. Return to "whatsapp" search.
> 
> Actual: Installed apps do not appear.
> Expected: Well, you know

This is a new bug, not a regression. Also happens on master.
I assume the apps are not associated with a 'whatsapp' tag
Flags: needinfo?(amirn)
Comment on attachment 822906 [details]
redirect to PR 13120.html

You're right. Great work!
Attachment #822906 - Flags: review- → review+
(Assignee)

Comment 9

5 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/f28e1811c9559f08a31e9be7f7d7de05e17f90fb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
blocking-b2g: --- → 1.3?
Clearing nom - this is already part of 1.3, so this doesn't need to be triaged.
blocking-b2g: 1.3? → ---
You need to log in before you can comment on or make changes to this bug.