Closed Bug 929441 Opened 6 years ago Closed 6 years ago

Stop unnecessarily setting a transform between emitting a path and stroking it

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

To support non-scaling stroke we undo the current transform by multiplying the inverse transform onto the gfxContext when we set up the stroke, which occurs between when we emit the path and when we actually call gfxContext::Stroke(). Changing the transform between the point when we emit the path and when we use it prevents us switching to Moz2D, so we should stop doing that. This patch doesn't stop us from doing that, but it does eliminate the useless matrix setting (setting of the identity matrix) is this scenario, which helps in tracking down the real cases where the setting is needed.
Attached patch patchSplinter Review
Attachment #820319 - Flags: review?
Attachment #820319 - Flags: review? → review+
https://hg.mozilla.org/mozilla-central/rev/a8680e083efa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 703159
Depends on: 949661
You need to log in before you can comment on or make changes to this bug.