Open Bug 929478 (tsan) Opened 11 years ago Updated 5 months ago

[meta] Make TSan (ThreadSanitizer) usable with Firefox

Categories

(Core :: Sanitizers, task)

Product:
Core
Component:
Sanitizers
Platform:
All
Linux
Type:
task

Tracking

()

People

(Reporter: decoder, Unassigned)

References

(Depends on 50 open bugs)

Details

(Keywords: meta, sec-want) 

This bug is meant for tracking all efforts related to making TSan usable with Firefox and once that is achieved, keeping our builds working and compatible with latest Firefox and TSan features.
Alias: tsan-maintenance
Depends on: 844755
Depends on: 847350
Depends on: 844784
Depends on: 931144
Depends on: 931149
Depends on: 829617
Depends on: 844766
Depends on: 931792
Depends on: 844759
Depends on: 939786
Depends on: 939788
Depends on: 939789
Depends on: 939790
Depends on: 939805
Depends on: 939807
Depends on: 940299
Depends on: 928808
Depends on: 962653
Depends on: 967455
Depends on: 967457
Depends on: 967462
Depends on: 967465
Depends on: 967469
Depends on: 967470
Depends on: 967474
Depends on: 967543
Depends on: 967544
Depends on: 967545
Depends on: 967922
Depends on: 967926
Depends on: 967928
Depends on: 967930
Depends on: 967932
Depends on: 967933
Depends on: 967935
Depends on: 967936
Depends on: 967938
Depends on: 967940
Depends on: 967943
Depends on: 974415
Depends on: 974416
Depends on: 974417
Depends on: 974418
Depends on: 974419
Depends on: 979254
Depends on: 979255
Depends on: 979278
Blocks: 935064
No longer blocks: 935064
Depends on: 935064
Depends on: 979293
Depends on: 1120537
Depends on: 1120545
Depends on: 1120579
Depends on: 1120591
Depends on: 1120611
Depends on: 1120631
Depends on: 1121216
Depends on: 1121669
Depends on: 1121672
Depends on: 1122021
Depends on: 1122070
Depends on: 1131711
Depends on: 1131714
Depends on: 1131715
Depends on: 1131759
Depends on: 1132109
Depends on: 1132170
Depends on: 1132171
Depends on: 1132172
Depends on: 1132201
Depends on: 1132212
Depends on: 1132519
Depends on: 1132572
Depends on: 1132908
Depends on: 1132938
Depends on: 1132966
Depends on: 1133024
Depends on: 1133025
Depends on: 1133028
Depends on: 1133053
Depends on: 1133057
Depends on: 1133064
Depends on: 1136004
Depends on: 1136762
Depends on: 1136844
Depends on: 1136849
Depends on: 1136889
Depends on: 1136922
Depends on: 1136926
Depends on: 1136932
Depends on: 1136952
Depends on: 1133051
Depends on: 1141563
Depends on: 1141565
Depends on: 1141568
Depends on: 1141579
Depends on: 1141583
Depends on: 1141586
Depends on: 1141593
Depends on: 1141644
Depends on: 1141667
Depends on: 1141692
Depends on: 1141741
Depends on: 1148397
Depends on: 1153394
Depends on: 1153409
Depends on: 1153415
Depends on: 1156891
Depends on: 1156909
Depends on: 1156929
Depends on: 1156938
Depends on: 1156966
Depends on: 1156974
Depends on: 1157322
Depends on: 1157323
Depends on: 1157343
Depends on: 1157350
Depends on: 1157382
Depends on: 1157392
Depends on: 1157447
Depends on: 1157454
Depends on: 1158871
Depends on: 1159280
Depends on: 1161170
Depends on: 1190935
Depends on: 1190951
Depends on: 1190969
Depends on: 1190976
Depends on: 1190985
Depends on: 1192031
Depends on: 1192067
Depends on: 1203585
Depends on: 1203655
Depends on: 1203658
Depends on: 1204042
Depends on: 1204043
Depends on: 1216526
Depends on: 1219401
Depends on: 1219403
Depends on: 1219405
Depends on: 1219409
Depends on: 1219418
Depends on: 1219910
Depends on: 1222101
Depends on: 1222782
Depends on: 1244247
Depends on: 1248915
Depends on: 1258183
Depends on: 1280637
Depends on: 1281253
Depends on: 1281275
Depends on: 1281381
Depends on: 1281385
Depends on: 1281292
Depends on: 1266458
Depends on: 1281390
Depends on: 844769
Depends on: 1288596
Assignee: choller → jseward
Depends on: 1291954
No longer depends on: 1288596
Depends on: 1457834
Depends on: 1318398
Depends on: 1367344
Depends on: 1533510
Depends on: 1533521
Depends on: 1533526
Depends on: 1533530
Depends on: 1587065
Depends on: 1587066
Depends on: 1587463
Depends on: 1587509
Depends on: 1587510
Depends on: 1506910
Depends on: 1506812
Depends on: 1587513
Depends on: 1587774
Depends on: 1589839
Depends on: 1588827
Depends on: 1590162
Depends on: 1590423
Depends on: 1590465
Depends on: 1590468
Depends on: 1589934
Depends on: 1592250
Depends on: 1592259
Depends on: 1598342
Depends on: 1580288
Depends on: 1585170
Depends on: 1548822
Depends on: 1600312
Depends on: 1600320
Depends on: 1600567
Depends on: 1600572
Depends on: 1600594
Depends on: 1600889
Depends on: 1600895
Depends on: 1601286
Depends on: 1601597
Depends on: 1601600
Depends on: 1601620
Depends on: 1601632
Depends on: 1601717
Depends on: 1601738
Depends on: 1601940
Depends on: 1601980
Depends on: 1602009
Depends on: 1602026
Depends on: 1602313
Depends on: 1603504
Depends on: 1606635
Depends on: 1606643
Depends on: 1606647
Depends on: 1606651
Depends on: 1606661
Depends on: 1606800
Depends on: 1606803
Depends on: 1606804
Depends on: 1606807
Depends on: 1606813
Depends on: 1606859
Depends on: 1606860
Depends on: 1606864
Depends on: 1607005
Depends on: 1607008
Depends on: 1607134
Depends on: 1607138
Depends on: 1607142
Depends on: 1607146
Depends on: 1607153
Depends on: 1607202
Depends on: 1607212
Depends on: 1607215
Depends on: 1607218
Depends on: 1607221
Depends on: 1607224
Depends on: 1607426
Depends on: 1607444
Depends on: 1607446
Depends on: 1607449
Depends on: 1607588
Depends on: 1607704
Depends on: 1607706
Depends on: 1607712
Depends on: 1607762
Depends on: 1607764
Depends on: 1608068
Depends on: 1608357
Depends on: 1608462
Depends on: 1609400
Depends on: 1612054
Depends on: 1612707
Depends on: tsan-tests-basic
Depends on: 1612713
Depends on: 1612740
Depends on: 1613384
Depends on: 1612212
Depends on: 1614605
Depends on: 1614637
Depends on: 1614646
Depends on: 1614697
Depends on: 1614706
Depends on: 1614708
Depends on: 1615014
Depends on: 1615017
Depends on: 1615045
Depends on: 1615121
Depends on: 1615125
Depends on: 1615228
Depends on: 1615275
Depends on: 1615265
Depends on: 1615569
Depends on: 1615725
Depends on: 1616342
Depends on: 1616120
Depends on: 1616027
Depends on: 1615608
Depends on: 1616507
Depends on: 845504
Alias: tsan-maintenance → tsan
Assignee: jseward → nobody
Component: Security Assurance: Applications → Sanitizers
Product: mozilla.org → Core
Version: other → Trunk
Keywords: meta
Summary: Make TSan (ThreadSanitizer) usable with Firefox → [meta] Make TSan (ThreadSanitizer) usable with Firefox

Chiming into this bug, please direct me to a more appropriate bug if there exists one.

I've noticed that tsan is currently running on linux64 docker image. This has been phased out for the most part on mozilla-central, with tests now running with ubuntu1804-test docker image.

I have a push where I made the necessary changes to have tsan run with ubuntu1804-test docker image, and I have some failures:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1%2C2%2C3&revision=e41b65c04476a324e12f6699f2bb7b6b3fbed695

xpcshell

  • X2 chunk reports a bunch of TEST-UNEXPECTED-FAIL that I assume are legitimate failures (i.e not slow tests).

mochitest-plain

  • a persistent failure of toolkit/content/tests/widgets/test_videocontrols.html can be seen in chunk 4.
  • multiple failures are observed in chunk 5, retriggers are underway.

I'd like to have all of tsan migrated over to use ubuntu1804 before the list of test suites grows. Should I skip all of the failing tests with skip-if = tsan?

Flags: needinfo?(choller)
Depends on: 1621195
Flags: needinfo?(choller)
Depends on: 1623034
Depends on: 1623541
Depends on: 1623542
Depends on: 1624563
Depends on: 1624842
Depends on: 1624897
Depends on: 1627572
Depends on: 1627683
Depends on: 1628780
Depends on: 1637977
Depends on: 1642653
Depends on: 1642906
Depends on: 1647378
Depends on: 1651446
Depends on: 1651449
Depends on: 1651509
Depends on: CVE-2020-15668
Depends on: mochitest_media_tsan
Depends on: 1651770
Depends on: 1652046
Depends on: 1652093
Depends on: 1652118
Depends on: 1652116
Depends on: 1652113
Depends on: 1652107
Depends on: 1652103
Depends on: 1652133
Depends on: 1652135
Depends on: 1652171
Depends on: 1652174
Depends on: 1652300
Depends on: 1627172
Depends on: 1647403
Depends on: 1629080
Depends on: 1645590
Depends on: 1633065
Depends on: 1637878
Depends on: 1647038
Depends on: 1643087
Depends on: 1644383
Depends on: 1627951
Depends on: 1635310
Depends on: 1648245
Depends on: 1638718
Depends on: 1643792
Depends on: 1646052
Depends on: 1630547
Depends on: 1642488
Depends on: 1633599
Depends on: 1647406
Depends on: 1647759
Depends on: 1645391
Depends on: 1644386
Depends on: 1629128
Depends on: 1647702
Depends on: 1647398
Depends on: 1647411
Depends on: 1636095
Depends on: 1633749
Depends on: 1633880
Depends on: 1647417
Depends on: 1645696
Depends on: 1640066
Depends on: 1644388
Depends on: 1629514
Depends on: 1632215
Depends on: 1647392
Depends on: 1637707
Depends on: 1630595
Depends on: 1648317
Depends on: 1642884
Depends on: 1637837
Depends on: 1647395
Depends on: 1645710
Depends on: 1630649
Depends on: 1626534
Depends on: 1644387
Depends on: 1649436
Depends on: 1642314
Depends on: 1649430
Depends on: 1631140
Depends on: 1626631
Depends on: 1640903
Depends on: 1642230
Depends on: 1647413, 1638212
Depends on: 1640332
Depends on: 1640445
Depends on: 1633239
Depends on: 1627487
Depends on: 1642086
Depends on: 1629299
Depends on: 1648860
Depends on: 1655518
Depends on: 1656266, 1656329, 1656268
Depends on: 1616462
Depends on: 1661527
Depends on: 1656326
Depends on: 1664534
Depends on: 1664535
Depends on: 1664536
Depends on: 1664547
Depends on: 1664799
Depends on: 1664802
Depends on: 1664803
Depends on: 1664831
Depends on: 1670982
Depends on: 1671572
Depends on: 1671574
Depends on: 1671577
Depends on: 1671601
Depends on: 1671691
Depends on: 1671692
Depends on: 1671923
Depends on: 1671931
Depends on: 1672155
Depends on: 1672162
Depends on: 1672230
Depends on: 1672253
Depends on: 1615123
Depends on: 1674467
Depends on: 1674770
Depends on: 1674773
Depends on: 1674776
Depends on: 1674835
Depends on: 1676257
Depends on: mochitest-bc-tsan
Depends on: 1677913
Depends on: 1680285
Depends on: 1680389
Depends on: 1680446
Depends on: 1681205
Depends on: 1681297
Depends on: 1681950
Depends on: 1682344
Depends on: 1682544
Depends on: 1682143
Depends on: 1682723
Depends on: 1682861
Depends on: 1682928
Depends on: 1682932
Depends on: 1682938
Depends on: 1682948
Depends on: 1682958
Depends on: 1683404
Depends on: 1683407
Depends on: 1683410
Depends on: 1683417
Depends on: 1683439
Depends on: 1659420
Depends on: 1676905
Depends on: 1647628
Depends on: 1683730
Depends on: 1683973
Depends on: 1685440
Depends on: 1685837
Depends on: 1683475
Depends on: 1685838
Depends on: 1686153
Depends on: 1686154
Depends on: 1686156
Depends on: 1686158
Depends on: 1685857
Depends on: 1685752
Depends on: 1681547
Depends on: 1685375
Depends on: 1686637
Depends on: 1687001
No longer depends on: 1281390