929525 - Email manual setup 'account' fields make automatic spelling corrections

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Brion Vibber]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

* build and install v1-train or v1.2 on ZTE Open
* open Email app
* set up new account
* fill in name/address fields, then click "manual setup"...
* tap into IMAP or SMTP "account" field
* type "brion"...
* type "."


Actual results:

* search suggestions popped up, and when we press "."...
* suddenly "brion." is replaced with "Briony."



Expected results:

* should not show spell suggestions and just let me type "brion.vibber" without it changing from under me halfway through

Comment 1

[Brion Vibber]

https://github.com/mozilla-b2g/gaia/pull/13017

Comment 2

[Brion Vibber]

https://github.com/mozilla-b2g/gaia/pull/13022 <- fixed pull request to be against master instead of v1.2

Comment 3

[Brion Vibber]

Attachment: Disable spell corrections in email manual config username fields

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 821031 [details] [review]
Disable spell corrections in email manual config username fields

Thanks for the fix!  Indeed, this is a case where we do not want auto-correct doing its thing.  I will merge this once the travis build goes green (I had to restart a test run) and mark the bug fixed/etc. once that happens.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

It took a lot of clicking, but the build went green.

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/13028
https://github.com/mozilla-b2g/gaia/commit/96bec788aac8311f53df0e490b0c4d97a7ae0e74

Thanks again for the fix!