929530 - Remove deprecated peerConnection functionality which has produced web console warnings since 24.

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Andrew McCreight [:mccr8]]

We want to change the semantics for "object" in WebIDL, and these apparently aren't even being used right now, so it would be good to remove them.  See discussion in bug 923904.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Renamed bug to capture the series of things we should remove at the same time, basically everything we deprecated and added a warning to in Bug 823512 (FF24):

- attribute versions of {local,global}Streams from PeerConnection
- attribute readyState
- callback attributes onicechange and ongatheringchange (*)
- calling createOffer/createAnswer without failureCallback

(I searched for 'deprecated' in https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=823512&attachment=750799 to produce this list)

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Remove peerConnection functionality deprecated w/warnings since 24

Try - https://tbpl.mozilla.org/?tree=Try&rev=e5d5a7713dd3

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/mozilla-central/rev/b490b5843f3c

Comment 4

[Andrew McCreight [:mccr8]]

Thanks for fixing this!

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Backed out for M2 bustage: 
https://hg.mozilla.org/mozilla-central/rev/64d531ae16c7

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&rev=a456d365e556

Fix to dom/bindings/test/test_exceptions_from_jsimplemented.html to not rely on the deprecated behavior

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Attachment: additional

Also made it complain on a few more paths

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 823112 [details] [diff] [review]
additional

Review of attachment 823112 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

With adjustment to the line number in the catch
https://hg.mozilla.org/mozilla-central/rev/70a8d374e544

Comment 10

[Kohei Yoshino [:kohei]]

Added to the site compat doc:
https://developer.mozilla.org/en-US/Firefox/Releases/27/Site_Compatibility

This doc doesn't mention those non-standard attributes:
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection