Closed Bug 929530 Opened 6 years ago Closed 6 years ago

Remove deprecated peerConnection functionality which has produced web console warnings since 24.

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox26 --- wontfix
firefox27 --- fixed

People

(Reporter: mccr8, Assigned: jib)

References

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [qa-])

Attachments

(2 files)

We want to change the semantics for "object" in WebIDL, and these apparently aren't even being used right now, so it would be good to remove them.  See discussion in bug 923904.
Renamed bug to capture the series of things we should remove at the same time, basically everything we deprecated and added a warning to in Bug 823512 (FF24):

- attribute versions of {local,global}Streams from PeerConnection
- attribute readyState
- callback attributes onicechange and ongatheringchange (*)
- calling createOffer/createAnswer without failureCallback

(I searched for 'deprecated' in https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=823512&attachment=750799 to produce this list)
Assignee: nobody → jib
Summary: Remove deprecated attribute versions of {local,global}Streams from PeerConnection → Remove deprecated peerConnection functionality which has produced web console warnings since 24.
Blocks: 929554
No longer blocks: 923904
Attachment #822911 - Flags: review?(rjesup) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Thanks for fixing this!
Backed out for M2 bustage: 
https://hg.mozilla.org/mozilla-central/rev/64d531ae16c7
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://tbpl.mozilla.org/?tree=Try&rev=a456d365e556

Fix to dom/bindings/test/test_exceptions_from_jsimplemented.html to not rely on the deprecated behavior
Attached patch additionalSplinter Review
Also made it complain on a few more paths
Attachment #823112 - Flags: review?(jib)
Comment on attachment 823112 [details] [diff] [review]
additional

Review of attachment 823112 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #823112 - Flags: review?(jib) → review+
With adjustment to the line number in the catch
https://hg.mozilla.org/mozilla-central/rev/70a8d374e544
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.