Closed Bug 929540 Opened 7 years ago Closed 7 years ago

Nightly builds don't start the browser console with -jsconsole

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: past, Assigned: past)

References

Details

Attachments

(1 file)

Using the -jsconsole commandline flag only works in local builds, not packaged ones, like nightly. We should probably be registering the new component in the package manifest.
Verified with mach package that this results in a -jsconsole flag that works as expected.
Attachment #820422 - Flags: review?(benjamin)
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment on attachment 820422 [details] [diff] [review]
Include the browser console command line handler in the browser packaging

Should we be removing

jsconsole-clhandler.manifest
jsconsole-clhandler.js

at the same time as this?
Attachment #820422 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Should we be removing
> 
> jsconsole-clhandler.manifest
> jsconsole-clhandler.js
> 
> at the same time as this?

I tried, but it doesn't work (Warning: unrecognized command line flag -jsconsole). I believe the devtools component extends the toolkit component or something to that effect.
(In reply to Panos Astithas [:past] from comment #3)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> > Should we be removing
> > 
> > jsconsole-clhandler.manifest
> > jsconsole-clhandler.js
> > 
> > at the same time as this?
> 
> I tried, but it doesn't work (Warning: unrecognized command line flag
> -jsconsole). I believe the devtools component extends the toolkit component
> or something to that effect.

Yes, we extend/override the toolkit component.

Thanks for the bug report and the quick patch. I just learned something new.
https://hg.mozilla.org/mozilla-central/rev/7fb62c0b9707
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.