Last Comment Bug 929540 - Nightly builds don't start the browser console with -jsconsole
: Nightly builds don't start the browser console with -jsconsole
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 27
Assigned To: Panos Astithas [:past]
:
: (Unavailable until Apr 3) [:bgrins]
Mentors:
Depends on:
Blocks: 860672
  Show dependency treegraph
 
Reported: 2013-10-22 09:38 PDT by Panos Astithas [:past]
Modified: 2013-10-23 05:54 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Include the browser console command line handler in the browser packaging (1.39 KB, patch)
2013-10-22 10:00 PDT, Panos Astithas [:past]
benjamin: review+
Details | Diff | Splinter Review

Description User image Panos Astithas [:past] 2013-10-22 09:38:51 PDT
Using the -jsconsole commandline flag only works in local builds, not packaged ones, like nightly. We should probably be registering the new component in the package manifest.
Comment 1 User image Panos Astithas [:past] 2013-10-22 10:00:01 PDT
Created attachment 820422 [details] [diff] [review]
Include the browser console command line handler in the browser packaging

Verified with mach package that this results in a -jsconsole flag that works as expected.
Comment 2 User image Benjamin Smedberg [:bsmedberg] 2013-10-22 10:08:55 PDT
Comment on attachment 820422 [details] [diff] [review]
Include the browser console command line handler in the browser packaging

Should we be removing

jsconsole-clhandler.manifest
jsconsole-clhandler.js

at the same time as this?
Comment 3 User image Panos Astithas [:past] 2013-10-22 11:06:41 PDT
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Should we be removing
> 
> jsconsole-clhandler.manifest
> jsconsole-clhandler.js
> 
> at the same time as this?

I tried, but it doesn't work (Warning: unrecognized command line flag -jsconsole). I believe the devtools component extends the toolkit component or something to that effect.
Comment 4 User image Panos Astithas [:past] 2013-10-22 13:18:01 PDT
https://hg.mozilla.org/integration/fx-team/rev/7fb62c0b9707
Comment 5 User image Mihai Sucan [:msucan] 2013-10-22 13:28:04 PDT
(In reply to Panos Astithas [:past] from comment #3)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> > Should we be removing
> > 
> > jsconsole-clhandler.manifest
> > jsconsole-clhandler.js
> > 
> > at the same time as this?
> 
> I tried, but it doesn't work (Warning: unrecognized command line flag
> -jsconsole). I believe the devtools component extends the toolkit component
> or something to that effect.

Yes, we extend/override the toolkit component.

Thanks for the bug report and the quick patch. I just learned something new.
Comment 6 User image Carsten Book [:Tomcat] 2013-10-23 05:54:18 PDT
https://hg.mozilla.org/mozilla-central/rev/7fb62c0b9707

Note You need to log in before you can comment on or make changes to this bug.