929540 - Nightly builds don't start the browser console with -jsconsole

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Using the -jsconsole commandline flag only works in local builds, not packaged ones, like nightly. We should probably be registering the new component in the package manifest.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Include the browser console command line handler in the browser packaging

Verified with mach package that this results in a -jsconsole flag that works as expected.

Comment 2

[Benjamin Smedberg]

Comment on attachment 820422 [details] [diff] [review]
Include the browser console command line handler in the browser packaging

Should we be removing

jsconsole-clhandler.manifest
jsconsole-clhandler.js

at the same time as this?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Should we be removing
> 
> jsconsole-clhandler.manifest
> jsconsole-clhandler.js
> 
> at the same time as this?

I tried, but it doesn't work (Warning: unrecognized command line flag -jsconsole). I believe the devtools component extends the toolkit component or something to that effect.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/7fb62c0b9707

Comment 5

[Mihai Sucan [:msucan]]

(In reply to Panos Astithas [:past] from comment #3)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> > Should we be removing
> > 
> > jsconsole-clhandler.manifest
> > jsconsole-clhandler.js
> > 
> > at the same time as this?
> 
> I tried, but it doesn't work (Warning: unrecognized command line flag
> -jsconsole). I believe the devtools component extends the toolkit component
> or something to that effect.

Yes, we extend/override the toolkit component.

Thanks for the bug report and the quick patch. I just learned something new.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7fb62c0b9707