929577 - [B2G][1.2][l10n][Homescreen] Greek: The Add to Home Screen title is truncated when adding web content to home screen

Status: VERIFIED WORKSFORME

(Mozilla Localizations :: el / Greek, defect)

Description

[Nikolai Khristoforov]

Attachment: Screenshot

The Add to Home Screen title gets truncated when the user tries to add web content to the home screen.

Repro Steps:
1) Updated Buri to 20131022004000
2) Choose Greek as the default language during set-up.
3) Open the browser app and open google.com
4) Select the Star button to bookmark the website.
5) Select the bottom option with four words to add to the home screen.
6) Verify the title is truncated.

Actual:
The Add to Home Screen title gets truncated.

Expected:
The full title would be displayed.

Environmental Variables:
Device: Buri v 1.2 COM RIL
BuildID: 20131022004000
Gaia: 00d5964eabf95a6a8a632420dfa36fc76dcbc9b7
Gecko: 7453a764f9a9
Version: 26.0a2
Firmware Version: 20131015

Repro frequency: 100%
See attached: Screenshot

Comment 1

[Alfredos-Panagiotis Damkalis [:fredy]]

Attachment: bug929577.patch

Changing string from "Add to Home Screen" to just "Add"

Comment 2

[alco]

Comment on attachment 820484 [details] [diff] [review]
bug929577.patch

Review of attachment 820484 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is ok but I need feedback from ux since the same string (used as title) is used as button text. It's fully shown on button but not when used as a title. So a user would be confused!

Comment 3

[Stephany Wilkes]

Alexandros, do you prefer a new string (i.e. Do you think the same strings should NOT be used?) or would you like to keep the same strings and have us do a visual adjustment for the title size? Just let us know. Thanks!

Comment 4

[Stephany Wilkes]

Also, please let me know if the fix in bug #908300 would correct this issue. It appears that it might.

Comment 5

[Alfredos-Panagiotis Damkalis [:fredy]]

Attachment: example - 1.6rem

I've just tested and if I change https://github.com/mozilla-b2g/gaia/blob/v1.2/shared/style/headers.css#L28 from 2.5 to 1.6 rem as it proposed in bug 908300 then it fits.

I attach a screenshot of this.

Comment 6

[Alfredos-Panagiotis Damkalis [:fredy]]

(In reply to Stephany Wilkes from comment #3)
> Alexandros, do you prefer a new string (i.e. Do you think the same strings
> should NOT be used?) or would you like to keep the same strings and have us
> do a visual adjustment for the title size? Just let us know. Thanks!

Resizing the title will be a good solution and it will correct also other truncated strings in several locales.

However in this case, I think that having different strings for the title and the button is a better behavior as they are two different entities. Even after resizing, some (future) locales (not the greek one apparently) may have issues if it remains one string.

Comment 7

[Axel Hecht [:Pike]]

Based on the triage in bug 942546, I'm resolving this WORKSFORME.

Comment 8

[sarsenyev]

As per comment 7, changing status to "Verified WORKSFORME"

Device: Buri 1.2 COM
BuildID: 20140102004001
Gaia: b1bc88386c781148a25091bf2eeee3ba217281d0
Gecko: 0c11156c7d9b
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: v1.2_20131115